Deprecate BindingBase.window#120998
Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom Mar 21, 2023
Merged
Conversation
flutter-dashboard
bot
added
the
framework
Member
Author
|
@pdblasi-google This is my suggestion for the deprecation message on |
33 tasks
goderbauer
force-pushed
the
deprecateWindow
branch
4 times, most recently
from
0f2847f to
f66fc71
Compare
flutter-dashboard
bot
added
the
a: tests
goderbauer
force-pushed
the
deprecateWindow
branch
2 times, most recently
from
d109cfc to
f0e08e3
Compare
loic-sharma
reviewed
Mar 15, 2023
Comment on lines
187
to
189
Member
There was a problem hiding this comment.
Consider:
Suggested change
| /// If a [BuildContext] is available, consider looking up the current | |
| /// [FlutterView] associated with that context via [View.of]. It gives access | |
| /// If a [BuildContext] is available, you can get the context's | |
| /// current [FlutterView] via [View.of]. It gives access |
I don't feel strongly about this
Member
Author
There was a problem hiding this comment.
I am gonna leave this as-is since our style guide doesn't like to use the word "you": https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#use-the-passive-voice-recommend-do-not-require-never-say-things-are-simple
loic-sharma
reviewed
Mar 15, 2023
Comment on lines
189
to
190
Member
There was a problem hiding this comment.
I prefer the language you use below in the See also section:
Suggested change
| /// to the same functionality as this deprecated property. However, some | |
| /// functionality has moved to the [PlatformDispatcher], which should be | |
| /// to the same functionality as this deprecated property. The | |
| /// platform-specific functionality has moved .... |
I don't feel strongly about this
loic-sharma
reviewed
Mar 15, 2023
Member
There was a problem hiding this comment.
Consider simpler language for non-native speakers:
Suggested change
| /// [platformDispatcher] exposed by this binding can be consulted directly for | |
| /// [platformDispatcher] exposed by this binding can be used directly for |
goderbauer
force-pushed
the
deprecateWindow
branch
from
f0e08e3 to
4d23cf2
Compare
goderbauer
force-pushed
the
deprecateWindow
branch
from
4d23cf2 to
c107892
Compare
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
This was referenced Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #116929.
Migration Guide: flutter/website#8283
Also adds ignores required for flutter/engine#39302.
To be submitted after deprecations for
flutter_test.