Update jdk in cirrus dockerfile image.#121251
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
I'm seeing a java exception while trying to build the dockerfile: https://cirrus-ci.com/task/5891245327777792
Step 23/39 : RUN yes "y" | "${ANDROID_TOOLS_ROOT}/tools/bin/sdkmanager" "tools" > /dev/null
---> Running in 5d830dd635f9
Exception in thread "main"
java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema
at com.android.repository.api.SchemaModule$SchemaModuleVersion.<init>(SchemaModule.java:156)
at com.android.repository.api.SchemaModule.<init>(SchemaModule.java:75)
at com.android.sdklib.repository.AndroidSdkHandler.<clinit>(AndroidSdkHandler.java:81)
at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:73)
at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:48)
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.annotation.XmlSchema
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
... 5 more
|
Yeah I know. Working on it. |
ricardoamador
requested review from
christopherfujino,
nehalvpatel and
reidbaker
|
I had to update with main but the cirrus tests are building and passing now: https://cirrus-ci.com/task/4596794747781120 |
dev/ci/docker_linux/Dockerfile
Outdated
There was a problem hiding this comment.
| RUN export CLASSPATH='/usr/share/jaxb/lib' | |
| ENV CLASSPATH='/usr/share/jaxb/lib' |
There was a problem hiding this comment.
since every RUN statement runs in its own shell, I don't think this statement affects any subsequent statements
There was a problem hiding this comment.
Hmm, you are correct. This leads me to believe that perhaps the jaxb import is not needed with the update to the commandline tools.
dev/ci/docker_linux/Dockerfile
Outdated
There was a problem hiding this comment.
Is there a helpful comment you can put here on how to update next time?
There was a problem hiding this comment.
Yeah I can add a note. I think in this case it was just Android updating their packaging and me not being aware of it until this PR. But I will add a note.
ricardoamador
force-pushed
the
update_jdk_cirrus
branch
from
a4d96e8 to
749bd2f
Compare
3 participants
The move of the engine to jdk 11 caused some breakages within cirrus as we had not updated that docker image to jdk 11. So compilation errors were happening because the java code was compiled with jdk 11 but being run for cirrus with jdk8.
List which issues are fixed by this PR. You must list at least one issue.
Fixes #121242
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.