Added identical(a,b) short circuit to painting Library lerp methods#121300
Closed
HansMuller wants to merge 3 commits intoflutter:masterfrom
Closed
Added identical(a,b) short circuit to painting Library lerp methods#121300HansMuller wants to merge 3 commits intoflutter:masterfrom
HansMuller wants to merge 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: text input
HansMuller
force-pushed
the
lerp_identical_painting
branch
2 times, most recently
from
365e2c4 to
74404e8
Compare
HansMuller
force-pushed
the
lerp_identical_painting
branch
from
74404e8 to
5d0c998
Compare
HansMuller
added a commit
to HansMuller/flutter
that referenced
this pull request
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle a common case in Foo.lerp(a, b, t): if a and b are identical, then just return a. This avoids needlessly constructing a new Foo and recursively lerping all of its properties. If a and b refer to the same const object, then we also preserve their singleton identity.
This PR is similar to #120829