Merged
Conversation
flutter-dashboard
bot
added
a: text input
8 tasks
LongCatIsLooong
force-pushed
the
update-font
branch
from
a054531 to
f04eee2
Compare
LongCatIsLooong
force-pushed
the
update-font
branch
from
1beb821 to
f4b5389
Compare
flutter-dashboard
bot
added
a: accessibility
justinmc
approved these changes
Mar 6, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Why are we changing the test font? Will it still be a blocky kind of font like Ahem?
It looks great that we don't have to specify "Ahem" everywhere, we don't need to use moreOrLessEquals, etc.
|
|
||
| // The label reduces the amount of space available for text, so the | ||
| // center is slightly lower. | ||
| expect(tester.getTopLeft(find.text(text)).dy, moreOrLessEquals(298.0, epsilon: .0001)); |
Contributor
There was a problem hiding this comment.
It's great that we can get rid of some moreOrLessEquals.
Contributor
Author
|
Yeah mostly because this font gives accurate metrics (unless |
Contributor
|
Sounds good, thanks! |
LongCatIsLooong
added
the
autosubmit
LongCatIsLooong
added a commit
that referenced
this pull request
Mar 6, 2023
This reverts commit 9f69a36.
LongCatIsLooong
added a commit
that referenced
this pull request
Mar 6, 2023
LongCatIsLooong
added a commit
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
Reland "Update test font (flutter#121306)"
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate framework tests before I can make the new test font the default.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.