Bottom appbar/sheet shadow property#121406
Merged
esouthren merged 17 commits intoflutter:masterfrom Mar 6, 2023
Merged
Conversation
flutter-dashboard
bot
added
f: material design
guidezpl
reviewed
Feb 27, 2023
HansMuller
reviewed
Feb 27, 2023
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
Creating a shadowColor theme property is a good move. Just small small-stuff feedback.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
QuncCccccc
reviewed
Mar 13, 2023
| Color? get surfaceTintColor => Theme.of(context).colorScheme.surfaceTint; | ||
|
|
||
| @override | ||
| Color get shadowColor => Colors.transparent; |
Contributor
8 tasks
8 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised re-land of #119819. Fixes #118150 and #118244.
Instead of hard-defaulting to no shadow in M3, we add a
shadowColorproperty tobottomAppBarandbottomSheet, and their respective themes.The M3 default is then set to
Colors.transparentshadow, but can be overridden by users.Updated M3 defaults:
Internal testing has been conducted and g3fix created (cl/512056372).
Pre-launch Checklist
///).