Removes single window assumptions from `flutter_test` by pdblasi-google · Pull Request #121549 · flutter/flutter

pdblasi-google · 2023-02-27T22:00:05Z

Adds TestFlutterView to wrap FlutterView and allow modification of properties for testing
Updates TestPlatformDispatcher to wrap its views in TestFlutterViews when they are changed
Adds viewOf to WidgetController for finding a TestFlutterView related to the results of a Finder
Exposes platformDispatcher and implicitView from WidgetController (and WidgetTester)
- This is so the related viewOf method, which uses the Finder API, will be in a consistent place with these methods and other Finder APIs

Resolves #117481

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

packages/flutter_test/lib/src/window.dart

packages/flutter_test/test/controller_test.dart

packages/flutter/test/widgets/container_test.dart

packages/flutter_test/lib/src/binding.dart

packages/flutter_test/lib/src/window.dart

goderbauer

This is looking pretty nicely!

packages/flutter_test/lib/src/controller.dart

packages/flutter_test/lib/src/window.dart

packages/flutter_test/test/window_test.dart

packages/flutter_test/lib/src/window.dart

goderbauer · 2023-03-03T01:48:18Z

Oh, one more thing: I seemed to recall that we considered whether we should auto-reset the testvalues on the TestFlutterView (and ideally TestFlutterPlatformDispatcher) between tests. Did you decide against doing that or did I just miss it?

pdblasi-google · 2023-03-03T18:18:26Z

Oh, one more thing: I seemed to recall that we considered whether we should auto-reset the testvalues on the TestFlutterView (and ideally TestFlutterPlatformDispatcher) between tests. Did you decide against doing that or did I just miss it?

I plan on doing that work in a separate PR. I want to do a revamp of how the testWidgets method does its setup and teardown to make it more consistent with the regular test framework. I'm not sure what to do with it in the meantime, but I'm leaning towards leaving it be and letting users forget to reset and solve the resetting issues themselves as needed.

goderbauer

packages/flutter_test/lib/src/window.dart

* Adds `TestFlutterView` to wrap `FlutterView` and allow modification of properties for testing * Updates `TestPlatformDispatcher` to wrap its views in `TestFlutterView`s when they are changed * Adds `viewOf` to `WidgetController` for finding a `TestFlutterView` related to the results of a `Finder` * Exposes `platformDispatcher` and `view` from `WidgetController` (and `WidgetTester`) * This is so the related `viewOf` method, which uses the `Finder` API, will be in a consistent place with these methods and other `Finder` APIs

This reverts commit f2dd19d.

…" (#122037) This reverts commit f2dd19d.

…r/flutter#121549)

goderbauer · 2023-03-08T17:05:10Z

packages/flutter_test/lib/src/window.dart

-  @override
-  ui.FrameData get frameData => _platformDispatcher.frameData;


I believe the accidental deletion of this getter caused b/272195069.

…r/flutter#121549)

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 27, 2023

pdblasi-google commented Feb 27, 2023

View reviewed changes

pdblasi-google requested a review from goderbauer March 1, 2023 00:58

goderbauer reviewed Mar 1, 2023

View reviewed changes

packages/flutter/test/widgets/container_test.dart Outdated Show resolved Hide resolved

flutter-dashboard bot added f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. labels Mar 1, 2023

pdblasi-google force-pushed the issues/117481 branch from 613cb7e to b1746bd Compare March 1, 2023 21:17

goderbauer reviewed Mar 1, 2023

View reviewed changes

goderbauer mentioned this pull request Mar 1, 2023

Remove ViewConfiguration and PlatformConfiguration from dart:ui #121742

Closed

pdblasi-google force-pushed the issues/117481 branch 3 times, most recently from aafe2ad to 20a5f6d Compare March 2, 2023 23:58

pdblasi-google requested a review from goderbauer March 3, 2023 00:23

goderbauer reviewed Mar 3, 2023

View reviewed changes

pdblasi-google mentioned this pull request Mar 3, 2023

Update TestPlatformDispatcher to use the same API as TestFlutterView #121901

Open

pdblasi-google force-pushed the issues/117481 branch 5 times, most recently from 1beddef to 18abbb9 Compare March 3, 2023 23:15

pdblasi-google requested a review from goderbauer March 3, 2023 23:16

goderbauer approved these changes Mar 3, 2023

View reviewed changes

packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved

pdblasi-google added 3 commits March 6, 2023 10:45

Moved TestWindow to the bottom of the file per PR request.

d342ce8

Marked FakeViewPadding as @immutable.

10eafc3

pdblasi-google force-pushed the issues/117481 branch from 983a652 to 10eafc3 Compare March 6, 2023 17:46

pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023

auto-submit bot merged commit f2dd19d into flutter:master Mar 6, 2023

pdblasi-google added a commit that referenced this pull request Mar 6, 2023

Revert "Removes single window assumptions from flutter_test (#121549)"

3e67b5e

This reverts commit f2dd19d.

pdblasi-google mentioned this pull request Mar 6, 2023

Revert "Removes single window assumptions from flutter_test" #122037

Merged

thkim1011 pushed a commit that referenced this pull request Mar 6, 2023

Revert "Removes single window assumptions from flutter_test (#121549)…

a53105d

…" (#122037) This reverts commit f2dd19d.

pdblasi-google mentioned this pull request Mar 6, 2023

Reland: Removes single window assumptions from flutter_test #122060

Merged

8 tasks

christopherfujino mentioned this pull request Mar 8, 2023

certain presubmit targets not scheduled #122157

Closed

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) flutter/packages#3410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023

f2dd19d Removes single window assumptions from flutter_test (flutte…

5514124

…r/flutter#121549)

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) flutter/packages#3416

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023

f2dd19d Removes single window assumptions from flutter_test (flutte…

b3168cf

…r/flutter#121549)

goderbauer reviewed Mar 8, 2023

View reviewed changes

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) flutter/packages#3418

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023

f2dd19d Removes single window assumptions from flutter_test (flutte…

a308fe4

…r/flutter#121549)

cyanglaz mentioned this pull request Mar 8, 2023

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes flutter/packages#3420

Merged

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Roll Flutter from f2f80059ff87 to 0cf593e79261 (45 revisions) flutter/packages#3421

Closed

goderbauer mentioned this pull request Mar 13, 2023

autosubmit bot submits without waiting for green Google Testing #122543

Closed

HansMuller mentioned this pull request Mar 16, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

f2dd19d Removes single window assumptions from flutter_test (flutte…

16371e9

…r/flutter#121549)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

f2dd19d Removes single window assumptions from flutter_test (flutte…

d04d852

…r/flutter#121549)

		@override
		ui.FrameData get frameData => _platformDispatcher.frameData;

Conversation

pdblasi-google commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Mar 3, 2023

Uh oh!

pdblasi-google commented Mar 3, 2023

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

goderbauer Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pdblasi-google commented Feb 27, 2023 •

edited

Loading