Use dart pub instead of dart __deprecated pub#121605
Merged
sigurdm merged 2 commits intoflutter:masterfrom Mar 6, 2023
Merged
Conversation
flutter-dashboard
bot
added
the
tool
| ); | ||
| } | ||
| return <String>[sdkPath, '__deprecated_pub', ...arguments]; | ||
| return <String>[sdkPath, '--no-analytics', 'pub', ...arguments]; |
Contributor
There was a problem hiding this comment.
you don't ever want analytics from these invocations? and is __deprecated_pub already not sending analytics?
Contributor
Author
There was a problem hiding this comment.
I think eventually we do want. But I wanted this PR to have minimal behavioral change. And we will probably have to revisit the analytics soon for the new pipeline anyway.
is __deprecated_pub already not sending analytics?
No - it doesn't. There was at the time questions about what our PDD allowed and not.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 13, 2023
This is no longer used after flutter/flutter#121605 Change-Id: Ifc33004dd3a87612bf7b92a50587d68a37d629d7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286927 Commit-Queue: Sigurd Meldgaard <[email protected]> Reviewed-by: Jonas Jensen <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves away from the old pub interface.
We are no longer parsing the output of pub, so not relying on the old format.
This takes care to run pub with
--no-analyticsto preserve behavior.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.