[flutter_tools/dap] Inform DAP client whether restart is supported#121610
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Mar 3, 2023
Merged
[flutter_tools/dap] Inform DAP client whether restart is supported#121610auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
Before this change, the Flutter adapter always sent "supportsRestartRequest: true" to the DAP client. This told the DAP client if the user clicks the "Restart" button on the debug toolbar that we (the DAP server) will handle the restart (allowing us to Hot Restart instead of a slower termination and restart of the entire debug session). However, Profile/Release mode do not support Hot Restart, so this would result in an error "Hot Restart failed". This change no longer sets `supportsRestartRequest: true` at startup, but instead waits for the `app.start` event, and sends the value of its `supportsRestart` field (an existing field that was already available in the `app.start` event). This results in Hot Restart being available for debug builds, but the DAP client/IDE performing a full debug session restart for other modes. Fixes Dart-Code/Dart-Code#4281.
flutter-dashboard
bot
added
the
tool
packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart
Outdated
Show resolved
Hide resolved
christopherfujino
approved these changes
Mar 3, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
nit about comment, but otherwise LGTM
…dart Co-authored-by: Christopher Fujino <[email protected]>
Contributor
Author
|
Fixed, thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the Flutter adapter always sent "supportsRestartRequest: true" to the DAP client. This told the DAP client if the user clicks the "Restart" button on the debug toolbar that we (the DAP server) will handle the restart (allowing us to Hot Restart instead of a slower termination and restart of the entire debug session).
However, Profile/Release mode do not support Hot Restart, so this would result in an error "Hot Restart failed".
This change no longer sets
supportsRestartRequest: trueat startup, but instead waits for theapp.startevent, and sends the value of itssupportsRestartfield (an existing field that was already available in theapp.startevent).This results in Hot Restart being available for debug builds, but the DAP client/IDE performing a full debug session restart for other modes.
Fixes Dart-Code/Dart-Code#4281.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.