Reland: Fix ExpansionTile for Android and iOS#121699
Closed
TahaTesser wants to merge 2 commits intoflutter:masterfrom
Closed
Reland: Fix ExpansionTile for Android and iOS#121699TahaTesser wants to merge 2 commits intoflutter:masterfrom
TahaTesser wants to merge 2 commits intoflutter:masterfrom
Conversation
chunhtai
reviewed
Mar 1, 2023
Contributor
chunhtai
left a comment
There was a problem hiding this comment.
LGTM except for non localized string
Contributor
Author
|
Closing to make a complete fix for all list tile variants in a single PR (as ExpansionTile is just using ListTile) to address all the issues in #121636 |
|
Hi @chunhtai @TahaTesser! I'm running into this same issue in 3.7.12. Do we know when this change will be available? Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #120881 which was reverted in #121624
fixes #120650
fixes #74963 (while relanding this i also fixed it for iOS as I was already investigating a fix for IOS before it was reverted)
code sample
Regression fix
Android Demo
VID_20230301172817.mp4
iOS demo
IMG_2241.MP4
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.