Skip to content

Adds vmservices for getting iOS build options#121736

Merged
auto-submit[bot] merged 9 commits intoflutter:masterfrom
chunhtai:issues/120405
Mar 6, 2023
Merged

Adds vmservices for getting iOS build options#121736
auto-submit[bot] merged 9 commits intoflutter:masterfrom
chunhtai:issues/120405

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Mar 1, 2023

part of #120405

The goal is to provide ios build options for devtool, so that it can display these options for the developers to choose from.

There will be a new vmservices to get app settings given a build option.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 1, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing.

@christopherfujino
Copy link
Contributor

As a high level question, would it make sense for this message to fetch info on android too (if configured)? or is that not needed?

@chunhtai
Copy link
Contributor Author

chunhtai commented Mar 1, 2023

As a high level question, would it make sense for this message to fetch info on android too (if configured)? or is that not needed?

There will be a different sets of vm services for Android. I decided to separate them out because the response format will be different. Plus Android and iOS will have different UI because the validation checks are different.

We could group them like

{
  result: success,
  android: {...},
  iOS: {...},
}

however I can't find a good reason to do that, the caller might as well call two different vm serivces to get the result. It is also likely we will display android and iOS in separate tab, it may only need result from one platform.

We could reuse this for macOS though since its format is almost the same as iOS, but I don't think we should do it unless we decide to reuse the same tab to display iOS and macOS result.

@christopherfujino
Copy link
Contributor

As a high level question, would it make sense for this message to fetch info on android too (if configured)? or is that not needed?

There will be a different sets of vm services for Android. I decided to separate them out because the response format will be different. Plus Android and iOS will have different UI because the validation checks are different.

We could group them like

{
  result: success,
  android: {...},
  iOS: {...},
}

however I can't find a good reason to do that, the caller might as well call two different vm serivces to get the result. It is also likely we will display android and iOS in separate tab, it may only need result from one platform.

We could reuse this for macOS though since its format is almost the same as iOS, but I don't think we should do it unless we decide to reuse the same tab to display iOS and macOS result.

fair enough. you've convinced me :)

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, but please update the dartdoc

@chunhtai
Copy link
Contributor Author

chunhtai commented Mar 2, 2023

Instead of drill through the callback, I decided to drill through the FlutterProject given how many layers I need to drill through, and the number of vmservices I will have to add in the future.

@chunhtai
Copy link
Contributor Author

chunhtai commented Mar 6, 2023

A friendly bump 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this argument ever get referenced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, I confused myself with all the drilling. fixed

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit about formatting, otherwise LGTM

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for swapping to named parameters, much easier to read 🙂

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023
@auto-submit auto-submit bot merged commit 026adb8 into flutter:master Mar 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants