Adds vmservices for getting iOS build options#121736
Adds vmservices for getting iOS build options#121736auto-submit[bot] merged 9 commits intoflutter:masterfrom
Conversation
|
As a high level question, would it make sense for this message to fetch info on android too (if configured)? or is that not needed? |
There will be a different sets of vm services for Android. I decided to separate them out because the response format will be different. Plus Android and iOS will have different UI because the validation checks are different. We could group them like {
result: success,
android: {...},
iOS: {...},
}however I can't find a good reason to do that, the caller might as well call two different vm serivces to get the result. It is also likely we will display android and iOS in separate tab, it may only need result from one platform. We could reuse this for macOS though since its format is almost the same as iOS, but I don't think we should do it unless we decide to reuse the same tab to display iOS and macOS result. |
fair enough. you've convinced me :) |
christopherfujino
left a comment
There was a problem hiding this comment.
code lgtm, but please update the dartdoc
|
Instead of drill through the callback, I decided to drill through the FlutterProject given how many layers I need to drill through, and the number of vmservices I will have to add in the future. |
|
A friendly bump 👍 |
There was a problem hiding this comment.
does this argument ever get referenced?
There was a problem hiding this comment.
nice catch, I confused myself with all the drilling. fixed
christopherfujino
left a comment
There was a problem hiding this comment.
nit about formatting, otherwise LGTM
Co-authored-by: Christopher Fujino <[email protected]>
jmagman
left a comment
There was a problem hiding this comment.
Thanks for swapping to named parameters, much easier to read 🙂
part of #120405
The goal is to provide ios build options for devtool, so that it can display these options for the developers to choose from.
There will be a new vmservices to get app settings given a build option.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.