Document on ScrollPhysics the requirement to override applyTo#121850
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Mar 10, 2023
Merged
Document on ScrollPhysics the requirement to override applyTo#121850auto-submit[bot] merged 3 commits intoflutter:masterfrom
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: scrolling
Piinks
reviewed
Mar 8, 2023
Piinks
approved these changes
Mar 8, 2023
gnprice
commented
Mar 8, 2023
Member
Author
|
Thanks!
Agreed. I haven't thought about what that could look like (or how to avoid or mitigate breakage from an API change), but something like that would be welcome. |
I missed this when first experimenting with a custom ScrollPhysics subclass a few weeks ago, which led me into about a half-hour of very confused debugging into the framework as I tried to figure out why my code wasn't running. This requirement is already stated on `applyTo` itself, but one won't necessarily see that unless there's already a reason to pay attention to `applyTo`. So it seems best to mention it on the documentation of the class itself.
gnprice
force-pushed
the
pr-scrollphysics-applyto-doc
branch
from
7b00393 to
97d53d7
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
…r#121850) Document on ScrollPhysics the requirement to override applyTo
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this when first experimenting with a custom ScrollPhysics subclass a few weeks ago, which led me into about a half-hour of very confused debugging into the framework as I tried to figure out why my code wasn't running.
This requirement is already stated on
applyToitself, but one won't necessarily see that unless there's already a reason to pay attention toapplyTo. So it seems best to mention it on the documentation of the class itself.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.