Skip to content

Fix license page title color issues#121872

Merged
HansMuller merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_license_page_title_color
Mar 6, 2023
Merged

Fix license page title color issues#121872
HansMuller merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_license_page_title_color

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Mar 3, 2023 •
edited
Loading

fixes #108991

Complete details in #108991 (comment)

Description

  1. This fixes the license page title color in the wide layout when foregroundColor is provided in the AppBarTheme.
  2. Fixes an issue with the license page title color in the nested layout for Material 3.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 3, 2023
@TahaTesser TahaTesser requested a review from HansMuller March 3, 2023 15:07
@HansMuller

This comment was marked as resolved.

Sign in to view
HansMuller
HansMuller reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Unfortunately there's a presubmit failure to contend with.

@TahaTesser

This comment was marked as resolved.

Sign in to view
@TahaTesser

This comment was marked as resolved.

Sign in to view
@TahaTesser TahaTesser force-pushed the fix_license_page_title_color branch from 8cecd29 to cf07a91 Compare March 6, 2023 11:16
@TahaTesser TahaTesser force-pushed the fix_license_page_title_color branch from 9b91d58 to 08e6742 Compare March 6, 2023 14:05
@TahaTesser
Copy link
Contributor Author

TahaTesser commented Mar 6, 2023

@HansMuller
Fixed the tests (the test window needed to be reset to the default size for other tests)

@TahaTesser TahaTesser requested a review from HansMuller March 6, 2023 15:34
HansMuller
HansMuller approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit efcc8b7 into flutter:master Mar 6, 2023
@TahaTesser TahaTesser deleted the fix_license_page_title_color branch March 6, 2023 16:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
efcc8b7 Fix license page title color issues (flutter/flutter#121872)
ddd96c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
efcc8b7 Fix license page title color issues (flutter/flutter#121872)
cf9fa54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
efcc8b7 Fix license page title color issues (flutter/flutter#121872)
78f61a5
@cyanglaz cyanglaz mentioned this pull request Mar 8, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
efcc8b7 Fix license page title color issues (flutter/flutter#121872)
fc5e77e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
efcc8b7 Fix license page title color issues (flutter/flutter#121872)
2491a64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

License page appBar text not visible

2 participants

@TahaTesser @HansMuller