Add IconButton.filled, IconButton.filledTonal, IconButton.outlined#121884
Merged
QuncCccccc merged 10 commits intoflutter:masterfrom Mar 4, 2023
Merged
Add IconButton.filled, IconButton.filledTonal, IconButton.outlined#121884QuncCccccc merged 10 commits intoflutter:masterfrom
IconButton.filled, IconButton.filledTonal, IconButton.outlined#121884QuncCccccc merged 10 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
d: api docs
QuncCccccc
changed the title
QuncCccccc
changed the title
IconButton.filled, IconButton.filledTonal, IconButton.outlined
QuncCccccc
force-pushed
the
icon_button_fatories
branch
from
64dae0a to
c1c730f
Compare
QuncCccccc
force-pushed
the
icon_button_fatories
branch
from
c1c730f to
e2db475
Compare
HansMuller
approved these changes
Mar 4, 2023
| }); | ||
| }, | ||
| ), | ||
| const SizedBox(width: 10,), |
Contributor
There was a problem hiding this comment.
In cases like this we don't usually include the trailing comma:
Suggested change
| const SizedBox(width: 10,), | |
| const SizedBox(width: 10), |
Here and elsewhere.
| @override | ||
| ButtonStyle defaultStyleOf(BuildContext context) { | ||
| return _IconButtonDefaultsM3(context); | ||
| switch (variant) { |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2023
Contributor
|
@QuncCccccc and @HansMuller, this PR is very nice, love it! However, and sadly based on my tests, it brings the same challenge to theming the A solution to this, with variant themes, is discussed in the related FAB issue here I will open a separate issue later for this case and reference this comment and other related issues. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111800
This PR is to add IconButton.filled, IconButton.tilledTonal and IconButton.outlined constructors.
Pre-launch Checklist
///).