Skip to content

[web] Ensure CanvasKit is served from the correct location#121902

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
mdebbar:serve_canvaskit
Mar 7, 2023
Merged

[web] Ensure CanvasKit is served from the correct location#121902
auto-submit[bot] merged 1 commit intoflutter:masterfrom
mdebbar:serve_canvaskit

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 3, 2023

When using --local-engine or --local-web-sdk we need to make sure that we are serving the locally built CanvasKit files instead of the ones in bin/cache.

Part of #118799

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 3, 2023
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023
@auto-submit auto-submit bot merged commit 95c2ad5 into flutter:master Mar 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
…21902)

[web] Ensure CanvasKit is served from the correct location
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants