Fix Gradle 7 warnings that are now errors in Gradle 8 by beroso · Pull Request #121958 · flutter/flutter

beroso · 2023-03-05T02:09:27Z

Pave the way to migrating to Gradle 8.
Following the manual: https://docs.gradle.org/current/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup

Fix #112858

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

flutter-dashboard · 2023-03-05T02:09:30Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

bartekpacia · 2023-03-05T16:04:57Z

Did you check that you can build your app with Gradle 8? Because I'm pretty sure you can't.

See issue #117043 (specifically this comment), which was a warning in Gradle 7.x but is a fatal error in Gradle 8.

CaseyHillers · 2023-03-05T23:20:27Z

We can test this by updating one of the tests to use Gradle 8. See #88540 for an example on the last time we did an upgrade to Gradle 7.

beroso · 2023-03-06T03:17:33Z

Did you check that you can build your app with Gradle 8? Because I'm pretty sure you can't.

See issue #117043 (specifically this comment), which was a warning in Gradle 7.x but is a fatal error in Gradle 8.

Sorry, I messed up here and I thought it was running properly. 🥲
I read your comment and tried to resolve the dependency problem. It's working but I don't know if it's the better approach.

beroso · 2023-03-06T03:38:34Z

@CaseyHillers Thank you for the hint!. I updated one benchmark test to Gradle 8 and hope it works

CaseyHillers · 2023-03-06T18:15:50Z

dev/benchmarks/complex_layout/android/build.gradle


    dependencies {
-        classpath 'com.android.tools.build:gradle:7.2.0'
+        classpath 'com.android.tools.build:gradle:7.3.0'


This test doesn't run on presubmit (see https://github.com/flutter/flutter/blob/master/.ci.yaml). @reidbaker do you know of any presubmit tests we could uprev to verify the gradle 8 change?

@camsim99 Is this something you could help with?

I think I got it. Needed to run dev/tools/bin/generate_gradle_lockfiles.dart

Did it run in presubmit? It will for sure run if you modify the ci.yaml file @CaseyHillers linked above to see a successful run, then revert the change. For instance, you can take the related tasks like this one and change presubmit: false to presubmit: true.

Ok @camsim99. I will try it

…so/flutter into 112858-fix-android-gradle-8

CaseyHillers · 2023-03-07T15:07:26Z

.ci.yaml

  - name: Linux_android complex_layout_android__compile
    recipe: devicelab/devicelab_drone
-    presubmit: false
+    presubmit: true


Test is passing on presubmit. This LGTM once you remove the presubmit run here.

bartekpacia · 2023-03-07T16:49:30Z

I'm happy to see this fixed. I also created a very similar PR but was 12h slower than @beroso! 😅 So I'm going to close it.

BTW, I believe this PR now also fixes #117043 in addition to #112858.

beroso · 2023-03-07T17:32:22Z

Thank you @bartekpacia ! Your comments was very helpful!

christopherfujino · 2023-03-09T21:30:39Z

I scheduled a re-run of Mac build_ios_framework_module_test because it timed out due to an ongoing infra issue we are having with our mac ARM64 bots.

Fix Gradle 7 warnings that are now errors in Gradle 8

…r/flutter#121958)

Pull the minimal set of changes from flutter 3.10 (in beta) into flutter 3.7 to support gradle 8.0 [124838](#124838) [Original PR](#121958) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. --------- Co-authored-by: André Sousa <[email protected]>

…r/flutter#121958)

Fixes #129471. Does so by doing a very similar thing that is done by #121958, but for a task that is specific to the add to app build process.

Fix Gradle 8 deprecated usages

2eff098

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 5, 2023

beroso added 2 commits March 5, 2023 23:58

Explict dependency from compressAssets on copyFlutterAssetsTask

8b1462e

Test if compressAssetsTask is defined

7b5a977

Bump benchmark to Gradle 8

62aa00c

beroso added 2 commits March 6, 2023 00:42

Bump benchmark to Gradle 8

3df8641

Merge branch 'master' into 112858-fix-android-gradle-8

ba60018

CaseyHillers reviewed Mar 6, 2023

View reviewed changes

beroso added 3 commits March 6, 2023 20:19

Bump example to Gradle 8

2d2fb8b

Merge branch '112858-fix-android-gradle-8' of https://github.com/bero…

508ecbe

…so/flutter into 112858-fix-android-gradle-8

Rum test on presubmit

6ed1948

beroso requested a review from keyonghan as a code owner March 7, 2023 02:47

CaseyHillers reviewed Mar 7, 2023

View reviewed changes

Remove presubmit run

8a26c35

reidbaker approved these changes Mar 7, 2023

View reviewed changes

CaseyHillers approved these changes Mar 7, 2023

View reviewed changes

bartekpacia mentioned this pull request Mar 7, 2023

Add support for Gradle 8 #121970

Closed

8 tasks

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023

auto-submit bot merged commit d7e8517 into flutter:master Mar 10, 2023

hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023

Fix Gradle 7 warnings that are now errors in Gradle 8 (flutter#121958)

f2b266d

Fix Gradle 7 warnings that are now errors in Gradle 8

engine-flutter-autoroll mentioned this pull request Mar 11, 2023

Roll Flutter from 5a279edc239f to f9ad42a32d7e (69 revisions) flutter/packages#3443

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023

d7e8517 Fix Gradle 7 warnings that are now errors in Gradle 8 (flutte…

3ac12db

…r/flutter#121958)

engine-flutter-autoroll mentioned this pull request Mar 12, 2023

Roll Flutter from 5a279edc239f to 9ba0d08ebc07 (72 revisions) flutter/packages#3445

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023

d7e8517 Fix Gradle 7 warnings that are now errors in Gradle 8 (flutte…

7020adb

…r/flutter#121958)

beroso deleted the 112858-fix-android-gradle-8 branch March 22, 2023 19:22

beroso mentioned this pull request Mar 22, 2023

Update AUTHORS #123266

Merged

This was referenced Mar 27, 2023

Task ':app:compressDebugAssets' uses this output of task ':app:copyFlutterAssetsDebug' without declaring an explicit or implicit dependency #117043

Closed

Run AGP update on all integration_tests in flutter/dev #123636

Open

ottoknowsnt mentioned this pull request Apr 16, 2023

Bump com.android.tools.build:gradle from 7.4.2 to 8.0.0 in /android ottoknowsnt/apneadiag#31

Closed

agacemi mentioned this pull request Apr 17, 2023

Gradle 8.0 is not useable with Flutter 3.7. #124838

Closed

2 tasks

reidbaker mentioned this pull request Apr 17, 2023

Cp for gradle 8.0 support in flutter 3.7 #124990

Merged

8 tasks

Tre0207 mentioned this pull request Apr 26, 2023

[CP] Gradle 8.0 support in flutter 3.7 (#124990) #125538

Closed

8 tasks

mohamedmohamedy mentioned this pull request Apr 27, 2023

Stable #125613

Closed

16 tasks

ilgnerND mentioned this pull request May 3, 2023

Promeira Versão #126019

Closed

16 tasks

Codeinstd mentioned this pull request May 9, 2023

[CP] Gradle 8.0 support in flutter 3.7 (#124990) #126305

Closed

8 tasks

aaarvaaan mentioned this pull request May 9, 2023

Stable #126327

Closed

16 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

d7e8517 Fix Gradle 7 warnings that are now errors in Gradle 8 (flutte…

f24d8fa

…r/flutter#121958)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

d7e8517 Fix Gradle 7 warnings that are now errors in Gradle 8 (flutte…

b0a7daa

…r/flutter#121958)

This was referenced May 12, 2023

Stable #126655

Closed

Stable #126656

Closed

arturw9 mentioned this pull request May 15, 2023

[CP] Gradle 8.0 support in flutter 3.7 (#124990) #126888

Closed

8 tasks

bartekpacia mentioned this pull request Jul 13, 2023

WorkValidationException on add-to-app project for task ':flutter:copyFlutterAssetsRelease' on Gradle 8.1 and AGP 8.0 #129471

Closed

2 tasks

gmackall mentioned this pull request Oct 26, 2023

Declare dependency on copyFlutterAssetsTask in bundleAarTask #137370

Merged

8 tasks

Conversation

beroso commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 5, 2023

Uh oh!

bartekpacia commented Mar 5, 2023

Uh oh!

CaseyHillers commented Mar 5, 2023

Uh oh!

beroso commented Mar 6, 2023

Uh oh!

beroso commented Mar 6, 2023

Uh oh!

CaseyHillers Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

reidbaker Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

beroso Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

camsim99 Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

beroso Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

CaseyHillers Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

beroso Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

bartekpacia commented Mar 7, 2023

Uh oh!

beroso commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

beroso commented Mar 5, 2023 •

edited

Loading

beroso commented Mar 7, 2023 •

edited

Loading