Add missing properties to ListTileTheme.merge#121975
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Mar 6, 2023
Merged
Add missing properties to ListTileTheme.merge#121975auto-submit[bot] merged 3 commits intoflutter:masterfrom
ListTileTheme.merge#121975auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
jpnurmi
force-pushed
the
list-tile-theme-merge
branch
from
c914b10 to
113284a
Compare
Contributor
|
Thanks for the PR! @jpnurmi This looks good, however, we're just testing explicit values in the When trying something like this, parent values are null in your test. print('mouseCursor: $mouseCursor, parent.mouseCursor: ${parent.mouseCursor}');
print('visualDensity: $visualDensity: parent.visualDensity: ${parent.visualDensity}');It would be great if the test checks that all properties actually getting merged with parent Looks like we're also missing |
TahaTesser
suggested changes
Mar 6, 2023
Co-authored-by: Taha Tesser <[email protected]>
TahaTesser
approved these changes
Mar 6, 2023
Contributor
TahaTesser
left a comment
TahaTesser
left a comment
There was a problem hiding this comment.
LGTM!
I need a second review from @HansMuller before merging this.
TahaTesser
changed the title
ListTileTheme.merge
TahaTesser
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
mouseCursorandvisualDensityarguments toListTileTheme.merge, makes it query the respective values from the parent theme, and passes them to the newly createdListTileThemeData. This ensures thatListTileThemeData.mouseCursorandListTileThemeData.visualDensityare not lost when usingListTileTheme.merge.Fixes: #121974
Pre-launch Checklist
///).