Add ZoomPageTransitionsBuilder.allowSnapshotting#122019
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 6, 2023
Merged
Conversation
flutter-dashboard
bot
added
d: api docs
Contributor
There was a problem hiding this comment.
I would also point out the ability to disable on a per route basis with route settings
bleroux
force-pushed
the
add_ZoomPageTransitionsBuilder_allowSnapshotting_property
branch
from
de259f2 to
e4140fd
Compare
bleroux
force-pushed
the
add_ZoomPageTransitionsBuilder_allowSnapshotting_property
branch
from
e4140fd to
0885365
Compare
bleroux
deleted the
add_ZoomPageTransitionsBuilder_allowSnapshotting_property
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ZoomPageTransitionsBuilder.allowSnapshottingproperty to make it possible to opt-out globally from zoom page transitions snapshotting. See #121701 (comment).This PR also adds an example.
Related Issue
Fixes #122017
Tests
Adds 3 tests for the new property.
Adds 1 test for the new example.