Fix TabBarView and TabBar animations are not synchronized#122021
Merged
HansMuller merged 1 commit intoflutter:masterfrom Mar 15, 2023
Merged
Conversation
769f0eb to
5267751
Compare
HansMuller
reviewed
Mar 15, 2023
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
[Sorry: I seem to have forgotten to review this one.]
HansMuller
approved these changes
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to interrupt an ongoing
TabBarViewanimation.Before this PR, when the
TabBarViewanimation is running (after the user selected one tab in the tab bar), it is not possible to interrupt this animation. So if the user selects another tab, theTabBarViewwill first finish the ongoing animation and then starts the new one). Because theTabBaranimation can be interrupted, this leads toTabBarViewandTabBaranimations being unsynchronized.Before:
Before.mp4
After:
After.mp4
Related Issue
Fixes #113020
Implementation choices
This PR combines several changes.
_childrenandoriginalChildren). Recreating_childrenWithKeyby callingensureUniqueKeysForListseems to be cheap and less error-prone.Tests
Adds 1 test.