ModalBottomSheetRoute: Remove gap at screen bottom with useSafeArea: true#122118
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 8, 2023
Merged
Conversation
flutter-dashboard
bot
added
f: material design
8 tasks
… true` Fixes flutter#121554. With `useSafeArea: true`, the added `SafeArea` now has `bottom: false`, to prevent a gap from appearing between the bottom edge of the sheet and the bottom edge of the screen, across the system intrusion there. The `useSafeArea: false` case still has a bug not addressed here; that's flutter#121752. I plan to submit a separate fix for that.
gnprice
force-pushed
the
pr-bottom-sheet-remove-gap
branch
from
39e73ee to
e10cd03
Compare
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 122118, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Member
|
@Hangyujin Would you take a look at the Google testing failure? This PR was only touching the |
hannah-hyj
added
the
autosubmit
Member
|
@gnprice The google testing failure is expected and manually approved. |
Member
|
Excellent. Thanks for your help! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Mar 10, 2023
This gets us flutter/flutter@23b7bbd89 (flutter/flutter#122118), which we'll use to make a nice prototype for the message action sheet, coming soon.
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Mar 10, 2023
This gets us flutter/flutter@23b7bbd89 (flutter/flutter#122118), which we'll use to make a nice prototype for the message action sheet, coming soon.
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
… true` (flutter#122118) ModalBottomSheetRoute: Remove gap at screen bottom with `useSafeArea: true`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121554.
With
useSafeArea: true, the addedSafeAreanow hasbottom: false, to prevent a gap from appearing between the bottom edge of the sheet and the bottom edge of the screen, across the system intrusion there.The
useSafeArea: falsecase still has a bug not addressed here; that's #121752. I plan to submit a separate fix for that.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.