Delete FlutterCommand.intArg(), which is not used anywhere#122124
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 8, 2023
bartekpacia:refactor/remove_unused_intarg
Merged
Delete FlutterCommand.intArg(), which is not used anywhere#122124auto-submit[bot] merged 1 commit intoflutter:masterfrom bartekpacia:refactor/remove_unused_intarg
FlutterCommand.intArg(), which is not used anywhere#122124auto-submit[bot] merged 1 commit intoflutter:masterfrom
bartekpacia:refactor/remove_unused_intarg
Conversation
…odebase It also has a bug in it, so it doesn't actually work.
Member
See #101595 for context. |
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
…odebase (flutter#122124) Delete `FlutterCommand.intArg()`, which is not used anywhere
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes dead code.
What's interesting is that it has a bug in it, so it probably was never used :) The correct implementation would be:
List which issues are fixed by this PR. You must list at least one issue.
Sorry, I think this is such a small change that it doesn't require one. But if I really must, I'll do, of course :)
Pre-launch Checklist
///).