Clear _scribbleCacheKey when connection closes#122145
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 8, 2023
Merged
Clear _scribbleCacheKey when connection closes#122145auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: text input
8 tasks
moffatman
force-pushed
the
selection_rects_cache
branch
from
fbfca25 to
5927d4c
Compare
LongCatIsLooong
approved these changes
Mar 8, 2023
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
moffatman
added
the
autosubmit
moffatman
force-pushed
the
selection_rects_cache
branch
from
5927d4c to
236c7bb
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
Clear _scribbleCacheKey when connection closes
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Contributor
Noob question: Is the connection created every time a text input is focused? @moffatman |
Contributor
Author
|
@hellohuanlin It might be, not actually sure. This fixes the issue observed when you tested in the |
Contributor
|
^ @LongCatIsLooong i'm wondering if you have context on question? Thanks! |
Contributor
|
Yeah whenever an input field gains focus it creates a connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TextInputConnection is recreated in the engine, it won't have its previous selectionRects remembered. But the framework still thinks it does, as
_scribbleCacheKeyisn't changed. The effect of this is that when refocusing a text field, the selectionRects will be missing until the text is changed. By clearing the cache-key, they will be properly re-sent when the TextInputConnection is re-opened.Part of #30476
Pre-launch Checklist
///).