Skip to content

Updates flutter/test/material to no longer use TestWindow#122337

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
pdblasi-google:issues/122240
Mar 14, 2023
Merged

Updates flutter/test/material to no longer use TestWindow#122337
auto-submit[bot] merged 1 commit intoflutter:masterfrom
pdblasi-google:issues/122240

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Mar 9, 2023 •
edited
Loading

Updates flutter/test/material to no longer use TestWindow

  • Adds FakeViewPadding.zero and updates view_test.dart and window_test.dart to use them
  • Removes no-shuffle tag from app_test.dart as the underlying issue seems to be resolved
  • Removes no-shuffle tag from text_field_test.dart as the underlying issue seems to be resolved

Resolves #122240

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 9, 2023
@pdblasi-google
Copy link
Contributor Author

pdblasi-google commented Mar 9, 2023

This also resolves #85160 for material's app_test.dart, scrollbar_test.dart, and text_field_test.dart.

goderbauer
goderbauer approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 10, 2023

auto label is removed for flutter/flutter, pr: 122337, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@pdblasi-google pdblasi-google changed the title Updates flutter/test/material to no longer use TestWindow WIP: Updates flutter/test/material to no longer use TestWindow Mar 10, 2023
@pdblasi-google pdblasi-google changed the title WIP: Updates flutter/test/material to no longer use TestWindow Updates flutter/test/material to no longer use TestWindow Mar 13, 2023
@pdblasi-google
Updates flutter/test/material to no longer use TestWindow
2ef0636 
* Adds `FakeViewPadding.zero` and updates `view_test.dart` and `window_test.dart` to use them
* Removes `no-shuffle` tag from `app_test.dart` as the underlying issue seems to be resolved
* Removes `no-shuffle` tag from `text_field_test.dart` as the underlying issue seems to be resolved
@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit auto-submit bot merged commit b2fc5f9 into flutter:master Mar 14, 2023
yaakovschectman added a commit that referenced this pull request Mar 14, 2023
@yaakovschectman
Revert "Updates flutter/test/material to no longer use TestWindow (…
a822013 
…#122337)"

This reverts commit b2fc5f9.
@yaakovschectman yaakovschectman mentioned this pull request Mar 14, 2023
Merged
yaakovschectman added a commit that referenced this pull request Mar 14, 2023
@yaakovschectman
Revert "Updates flutter/test/material to no longer use TestWindow (…
46a8106 
…#122337)" (#122636)

This reverts commit b2fc5f9.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
b2fc5f9 Updates flutter/test/material to no longer use TestWindow (…
ae00bc7 
…flutter/flutter#122337)
@HansMuller HansMuller mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
b2fc5f9 Updates flutter/test/material to no longer use TestWindow (…
00a275d 
…flutter/flutter#122337)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
b2fc5f9 Updates flutter/test/material to no longer use TestWindow (…
9c6695b 
…flutter/flutter#122337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update flutter/test/material to no longer use TestWindow

2 participants

@pdblasi-google @goderbauer