Skip to content

Updates integration_test to no longer use TestWindow#122358

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
pdblasi-google:issues/122243
Mar 14, 2023
Merged

Updates integration_test to no longer use TestWindow#122358
auto-submit[bot] merged 1 commit intoflutter:masterfrom
pdblasi-google:issues/122243

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Mar 10, 2023 •
edited
Loading

Updates integration_test to no longer use TestWindow.

Resolves #122243.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Mar 10, 2023
goderbauer
goderbauer approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdblasi-google pdblasi-google changed the title Updates integration_test to no longer use TestWindow WIP: Updates integration_test to no longer use TestWindow Mar 10, 2023
@pdblasi-google pdblasi-google changed the title WIP: Updates integration_test to no longer use TestWindow Updates integration_test to no longer use TestWindow Mar 13, 2023
@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit auto-submit bot merged commit e22e8f2 into flutter:master Mar 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
e22e8f2 Updates integration_test to no longer use TestWindow (flu…
b956f3d 
…tter/flutter#122358)
@pdblasi-google pdblasi-google deleted the issues/122243 branch March 15, 2023 18:09
@HansMuller HansMuller mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e22e8f2 Updates integration_test to no longer use TestWindow (flu…
f927f80 
…tter/flutter#122358)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e22e8f2 Updates integration_test to no longer use TestWindow (flu…
09c8fbe 
…tter/flutter#122358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update integration_test to no longer use TestWindow

2 participants

@pdblasi-google @goderbauer