Skip to content

Cleanup flutter config output#122384

Merged
mit-mit merged 7 commits intoflutter:masterfrom
mit-mit:confighelp
Apr 21, 2023
Merged

Cleanup flutter config output#122384
mit-mit merged 7 commits intoflutter:masterfrom
mit-mit:confighelp

Conversation

@mit-mit
Copy link
Member

@mit-mit mit-mit commented Mar 10, 2023 •
edited
Loading

I'd like to propose that we cleanup the flutter config help output, by only printing channel notes for options that are limited to a subset of the possible branches.

Current output

Usage: flutter config [arguments]
-h, --help                                      Print this usage information.
    --[no-]analytics                            Enable or disable reporting anonymously tool usage statistics and crash
                                                reports.
    --clear-ios-signing-cert                    Clear the saved development certificate choice used to sign apps for iOS
                                                device deployment.
    --android-sdk                               The Android SDK directory.
    --android-studio-dir                        The Android Studio install directory.
    --build-dir=<out/>                          The relative path to override a projects build directory.
    --[no-]enable-web                           Enable or disable Flutter for web. This setting will take effect on the
                                                master, beta, and stable channels.
    --[no-]enable-linux-desktop                 Enable or disable support for desktop on Linux. This setting will take effect
                                                on the master, beta, and stable channels.
    --[no-]enable-macos-desktop                 Enable or disable support for desktop on macOS. This setting will take effect
                                                on the master, beta, and stable channels.
    --[no-]enable-windows-desktop               Enable or disable support for desktop on Windows. This setting will take
                                                effect on the master, beta, and stable channels.
    --[no-]single-widget-reload-optimization    Enable or disable Hot reload optimization for changes to class body of a
                                                single widget. This setting will take effect on the master and beta channels.
    --[no-]enable-android                       Enable or disable Flutter for Android. This setting will take effect on the
                                                master, beta, and stable channels.
    --[no-]enable-ios                           Enable or disable Flutter for iOS. This setting will take effect on the
                                                master, beta, and stable channels.
    --[no-]enable-fuchsia                       Enable or disable Flutter for Fuchsia. This setting will take effect on the
                                                master channel.
    --[no-]enable-custom-devices                Enable or disable Early support for custom device types. This setting will
                                                take effect on the master, beta, and stable channels.
    --clear-features                            Remove all configured features and restore them to the default values.

Run "flutter help" to see global options.

Update after PR

Usage: flutter config [arguments]
-h, --help                                      Print this usage information.
    --[no-]analytics                            Enable or disable reporting anonymously tool usage statistics and crash
                                                reports.
    --clear-ios-signing-cert                    Clear the saved development certificate choice used to sign apps for iOS
                                                device deployment.
    --android-sdk                               The Android SDK directory.
    --android-studio-dir                        The Android Studio install directory.
    --build-dir=<out/>                          The relative path to override a projects build directory.
    --[no-]enable-web                           Enable or disable Flutter for web.
    --[no-]enable-linux-desktop                 Enable or disable support for desktop on Linux.
    --[no-]enable-macos-desktop                 Enable or disable support for desktop on macOS.
    --[no-]enable-windows-desktop               Enable or disable support for desktop on Windows.
    --[no-]single-widget-reload-optimization    Enable or disable Hot reload optimization for changes to class body of a
                                                single widget.
                                                This setting applies to only the master and beta channels.
    --[no-]enable-android                       Enable or disable Flutter for Android.
    --[no-]enable-ios                           Enable or disable Flutter for iOS.
    --[no-]enable-fuchsia                       Enable or disable Flutter for Fuchsia.
                                                This setting applies to only the master channel.
    --[no-]enable-custom-devices                Enable or disable Early support for custom device types.
    --clear-features                            Remove all configured features and restore them to the default values.

Run "flutter help" to see global options.

This is a draft PR as I havn't updated tests yet (i'll do that if there is agreement that this change is good).

List which issues are fixed by this PR. You must list at least one issue.
No issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
TBD

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 10, 2023
@mit-mit
Copy link
Member Author

mit-mit commented Mar 15, 2023

@christopherfujino @Jasguerrero wdyt?

@christopherfujino
Copy link
Contributor

christopherfujino commented Mar 15, 2023

SGTM

@mit-mit mit-mit marked this pull request as ready for review April 17, 2023 14:14
@mit-mit
Copy link
Member Author

mit-mit commented Apr 17, 2023

@christopherfujino I fixed the test, can you PTAL?

@eliasyishak
Copy link
Contributor

eliasyishak commented Apr 20, 2023

@mit-mit you may want to update the branch with the latest changes, there was a test (SliverReorderableList item has correct semantics) that has been fixed yesterday

@christopherfujino christopherfujino requested review from eliasyishak and removed request for christopherfujino April 20, 2023 20:20
@mit-mit
Copy link
Member Author

mit-mit commented Apr 21, 2023

@eliasyishak done!

@mit-mit mit-mit added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 21, 2023

auto label is removed for flutter/flutter, pr: 122384, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@mit-mit
Copy link
Member Author

mit-mit commented Apr 21, 2023 •
edited
Loading

auto label is removed

oh, I thought this label was "auto merge once approved"

eliasyishak
eliasyishak approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you should be able to add back your auto submit label now

@mit-mit mit-mit merged commit dc481b2 into flutter:master Apr 21, 2023
@mit-mit mit-mit deleted the confighelp branch April 21, 2023 14:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
271c102
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
526e260
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
2b8ad1f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
5c95d46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
f9010f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
0ea0dbb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
c44b4ac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
6f240f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
83c4a41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
b90562a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
c9057e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
dc481b2 Cleanup flutter config output (flutter/flutter#122384)
c132f0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eliasyishak eliasyishak eliasyishak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mit-mit @christopherfujino @eliasyishak