Run dart command to update widget defaults#122557
Merged
guidezpl merged 2 commits intoflutter:masterfrom Mar 15, 2023
Merged
Conversation
flutter-dashboard
bot
added
f: material design
This was referenced Mar 13, 2023
guidezpl
reviewed
Mar 14, 2023
|
|
||
| @override | ||
| Color? get dividerColor => ${componentColor("md.comp.primary-navigation-tab.divider")}; | ||
| Color? get dividerColor => _colors.surfaceVariant; |
Member
There was a problem hiding this comment.
It's possible the guidelines are wrong, could you please revert this for the time being and file a bug at go/guidelinebug?
Contributor
Author
There was a problem hiding this comment.
I see. Just reverted the token and the template. Also filed a bug here: b/273575840. Thanks!
guidezpl
approved these changes
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix following things:
shadowColorinBottomAppBarTemplateis different from the default_BottomAppBarDefaultsM3code. Should both beColor?.The above changes are done by running
dart dev/tools/gen_defaults/bin/gen_defaults.dart.Also the tabs token file removed the divider color, but from the material design website, it should still be ColorScheme.surfaceVariant. So I changed the according field in tabs_template.
Related to #122388 and #121406
Pre-launch Checklist
///).