Don't require .packages file for flutter packages command#12258
Merged
tvolkert merged 1 commit intoflutter:masterfrom Sep 26, 2017
tvolkert:fix
Merged
Don't require .packages file for flutter packages command#12258tvolkert merged 1 commit intoflutter:masterfrom tvolkert:fix
flutter packages command#12258tvolkert merged 1 commit intoflutter:masterfrom
tvolkert:fix
Conversation
(it's the command that populates the .packages file)
Contributor
Author
|
Tests to follow, but sending this out to unblock broken builds on other repos. |
Member
|
Thanks! |
Hixie
reviewed
Sep 26, 2017
|
|
||
| // Validate the current package map only if we will not be running "pub get" later. | ||
| if (!(_usesPubOption && argResults['pub'])) { | ||
| if (parent?.name != 'packages' && !(_usesPubOption && argResults['pub'])) { |
Contributor
Author
See comment above. Writing tests as we speak, but I wanted to unbreak the build first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(it's the command that populates the .packages file)