Skip to content

Reland: Updates flutter/test/rendering to no longer use TestWindow#122621

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
pdblasi-google:issues/122241
Mar 14, 2023
Merged

Reland: Updates flutter/test/rendering to no longer use TestWindow#122621
auto-submit[bot] merged 1 commit intoflutter:masterfrom
pdblasi-google:issues/122241

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Mar 14, 2023 •
edited
Loading

Updates flutter/test/rendering to no longer use TestWindow.

Resolves #122241.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 14, 2023
@goderbauer
Copy link
Member

goderbauer commented Mar 14, 2023

Looks like there's a merge conflict on this one.

goderbauer
goderbauer approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit auto-submit bot merged commit 714389b into flutter:master Mar 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
714389b Reland: Updates flutter/test/rendering to no longer use `Te…
b1446ae 
…stWindow` (flutter/flutter#122621)
@pdblasi-google pdblasi-google deleted the issues/122241 branch March 15, 2023 18:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
714389b Reland: Updates flutter/test/rendering to no longer use `Te…
629f156 
…stWindow` (flutter/flutter#122621)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
714389b Reland: Updates flutter/test/rendering to no longer use `Te…
2602994 
…stWindow` (flutter/flutter#122621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update flutter/test/rendering to no longer use TestWindow

2 participants

@pdblasi-google @goderbauer