Add Flags class.#12268
Merged
tvolkert merged 2 commits intoflutter:masterfrom Sep 28, 2017
tvolkert:bundle
Merged
Conversation
This class lives in the Context and allows callers to "inject" flag values, where flag values are first extracted from the command arguments, then from the global arguments as a fallback.
yjbanov
approved these changes
Sep 27, 2017
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
LGTM with some nitpicking.
|
|
||
| Flags get flags => context?.getVariable(Flags) ?? const _EmptyFlags(); | ||
|
|
||
| class Flags { |
Contributor
There was a problem hiding this comment.
Docs explaining the existence of this class would be great.
|
|
||
| dynamic operator [](String key) { | ||
| final ArgResults commandResults = _globalResults.command; | ||
| if (commandResults?.options?.contains(key) ?? false) { |
Contributor
There was a problem hiding this comment.
nit: we don't use {} for single-line if blocks.
|
|
||
| import 'context.dart'; | ||
|
|
||
| Flags get flags => context?.getVariable(Flags) ?? const _EmptyFlags(); |
|
|
||
| dynamic operator [](String key) { | ||
| final ArgResults commandResults = _globalResults.command; | ||
| if (commandResults?.options?.contains(key) ?? false) { |
Contributor
There was a problem hiding this comment.
nit: ?? false does work, but I think it's less readable than:
final options = commandResults?.options;
if (options != null && options.contains(key)) {
...
Member
There was a problem hiding this comment.
+1 in both agreement and nitpickiness. ;-)
| final ArgResults commandResults = _globalResults.command; | ||
| if (commandResults?.options?.contains(key) ?? false) { | ||
| return commandResults[key]; | ||
| } else if (_globalResults.options.contains(key)) { |
Contributor
There was a problem hiding this comment.
If commandResults.options can be null, why can't _globalResults.options?
Contributor
Author
There was a problem hiding this comment.
commandResults.options can't be null, but commandResults can be null, which can make commandResults?.options null, which necessitates the second ?.
cbracken
reviewed
Sep 27, 2017
| return commandResults[key]; | ||
| } else if (_globalResults.options.contains(key)) { | ||
| return _globalResults[key]; | ||
| } |
Member
There was a problem hiding this comment.
Since none of the conditional code is > 1 LoC, kill the curly brackets.
cbracken
reviewed
Sep 27, 2017
| } | ||
|
|
||
| final ArgResults _globalResults; | ||
|
|
Member
There was a problem hiding this comment.
Worth adding a bool contains(String key)? Given that null isn't a valid value, it's probably fine as is; just thinking of consistency with package:args.
cbracken
approved these changes
Sep 27, 2017
Member
|
I've been dying for a chance to use that, sorry. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Sep 14, 2019
[email protected]:flutter/engine.git/compare/e12decfdd210...fdb7bbf git log e12decf..fdb7bbf --no-merges --oneline 2019-09-13 [email protected] Revert "Close the tree (#12268)" (flutter/engine#12272) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
flutter#40469) [email protected]:flutter/engine.git/compare/e12decfdd210...fdb7bbf git log e12decf..fdb7bbf --no-merges --oneline 2019-09-13 [email protected] Revert "Close the tree (flutter#12268)" (flutter/engine#12272) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class lives in the Context and allows callers to "inject"
flag values, where flag values are first extracted from the
command arguments, then from the global arguments as a fallback.