Add dimenstion for arm packaging#122770
Conversation
XilaiZhang
requested review from
christopherfujino,
godofredoc and
itsjustkevin
| tags: > | ||
| ["framework", "hostonly", "shard", "mac"] | ||
| dimensions: | ||
| cpu: "arm64" |
There was a problem hiding this comment.
I'll defer final approval. This file is confusing however, I see arm64 being specified under cpu: arm64 https://github.com/flutter/flutter/blob/master/.ci.yaml#L90 and properties.tags: ["arm64"] https://github.com/flutter/flutter/blob/master/.ci.yaml#L3331, and then here under dimensions.cpu: arm64.
There was a problem hiding this comment.
Umm that's true, if it is specified in the general properties it should have been inherited
There was a problem hiding this comment.
To keep the dart internal builds simple they do not implement the logic post-process the ci.yaml file. They only see the specific target information.
There was a problem hiding this comment.
By the way we have an open bug to simplify properties and dimensions across flutter-infra, ci.yaml and cocoon. Turns out we have different implementations on those 3 places.
There was a problem hiding this comment.
Thanks for explaining! Didn't know dart internal uses a different parser for yaml
XilaiZhang
added
the
autosubmit
Add dimenstion for arm packaging
Add dimenstion for arm packaging
3 participants
context: #122769