Deprecates TestWindow#122824
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Mar 21, 2023
Merged
Conversation
flutter-dashboard
bot
added
a: tests
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
reviewed
Mar 16, 2023
loic-sharma
approved these changes
Mar 16, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
This looks good to me but please also get an approval from someone who has more experience with our deprecation process :)
goderbauer
reviewed
Mar 17, 2023
pdblasi-google
force-pushed
the
issues/121915
branch
3 times, most recently
from
3f714b0 to
eeb05ed
Compare
Merged
11 tasks
33 tasks
Member
|
Looks like the upstream fixes to the packages repo rolled in with #123117. Rebasing this PR should hopefully turn the "Linux flutter_plugins" check green. I believe we are ready to submit this one then? |
* Adds `Deprecated` annotations to `TestWindow` and its constructors. * Adds `Deprecated` annotations to all properties and methods on `TestWindow` except `noSuchMethod`. * Adds `Deprecated` annotation to `TestWidgetsFlutterBinding.window`. * Adds `flutter_test` specific deprecation documentation to `TestWidgetsFlutterBinding.window`.
pdblasi-google
force-pushed
the
issues/121915
branch
from
eeb05ed to
b6da817
Compare
pdblasi-google
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
This was referenced Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
TestWindowDeprecatedannotations toTestWindowand its constructors.Deprecatedannotations to all properties and methods onTestWindowexceptnoSuchMethod.Deprecatedannotation toTestWidgetsFlutterBinding.window.flutter_testspecific deprecation documentation toTestWidgetsFlutterBinding.window.Resolves #121915.
Pre-launch Checklist
///).