[Tool] [Windows] Output app path on build completion#122928
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Mar 20, 2023
Merged
[Tool] [Windows] Output app path on build completion#122928auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
d39f10f to
32e1e11
Compare
loic-sharma
commented
Mar 18, 2023
Member
Author
There was a problem hiding this comment.
This is the reland's fix. The original change used the app's name according to the pubspec.yaml file and assumed that matched CMake's app name. However, these files can get out of sync.
32e1e11 to
c098e6f
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c098e6f(#122928): it uses CMake's app name instead ofpubspec.yaml's app name as these can get out of sync.Improves the build output:
This matches the behavior of other Flutter platforms like Android.
Part of #120127
Flutter run
Flutter build
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.