Reland "Fix bug with clicking Copy or Select All within contextMenu"#122973
Merged
auto-submit[bot] merged 28 commits intoflutter:masterfrom Mar 20, 2023
Merged
Conversation
…ontextMenu (flutter#120081)" (flutter#122832)" This reverts commit 6711411.
flutter-dashboard
bot
added
the
framework
… github.com:acumen1005/flutter into revert-122832-revert-120081-selection-overlay-issue
acumen1005
changed the title
Copy or Select All within contextMenu""Copy or Select All within contextMenu""
justinmc
changed the title
Copy or Select All within contextMenu""Copy or Select All within contextMenu""
justinmc
changed the title
Copy or Select All within contextMenu""Copy or Select All within contextMenu"
justinmc
approved these changes
Mar 20, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for finding the problem and opening a new PR so quick!
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #122832
Relands #120081 by skipping a failing test that shouldn't have run on web.