Remove unused replacement from Visibility.maintain#123039
Remove unused replacement from Visibility.maintain#123039auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
LGTM, but dartdocs for |
|
Ah, right. Updated by removing that line altogether. Since we don't support non-nullsafe mode anymore, the note about child not being null is also redundant. |
|
test-exempt: removing code |
goderbauer
added
the
autosubmit
3 participants
While reviewing #122585 I noticed that the
replacementparameter onVisibility.maintaindoesn't make any sense. It is always ignored because the constructor forcesmaintainStateto true:flutter/packages/flutter/lib/src/widgets/visibility.dart
Lines 139 to 140 in e0ea39f
Therefore, this PR removed the
replacementparameter fromVisibility.maintain.