[flutter_tools] remove fuchsia tooling#123043
[flutter_tools] remove fuchsia tooling#123043jonahwilliams wants to merge 7 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: text input
| - bin/** | ||
| - .ci.yaml | ||
|
|
||
| - name: Linux fuchsia_precache |
There was a problem hiding this comment.
So we can delete the code in the engine builders that uploads this stuff?
What about the code that builds it?
There was a problem hiding this comment.
Not sure about engine builders, probably no since google3 artifacts still roll through flutter.
There was a problem hiding this comment.
the tooling itself isn't used though
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM. I thought CI would start failing on this but neat.
|
I guess the internal failures can just get patched to not depend on this code? |
|
Following up on g3 |
|
Seems good to go but not sure about the Google testing failure. Are we blocked on an investigation? |
|
Blocked on investigating g3 linkage |
|
Should we re-open #123084 and land it in the mean time to fix FFX problems for people? |
|
Yes please! |
|
@jonahwilliams I'm guessing we're still blocked? |
|
Sorry, I need to follow up on how this is being used in g3. In the meantime, Dan landed a fix that makes sure this is disabled if the user has not opted in. I'm going to close this for now |
5 participants
Fixes #123040