Add a check for gradle failing due to missing licenses#12318
Merged
mit-mit merged 2 commits intoflutter:masterfrom Sep 29, 2017
mit-mit:licenses
Merged
Add a check for gradle failing due to missing licenses#12318mit-mit merged 2 commits intoflutter:masterfrom mit-mit:licenses
mit-mit merged 2 commits intoflutter:masterfrom
mit-mit:licenses
Conversation
jakobr-google
approved these changes
Sep 29, 2017
| final Match licenseMatch = licenseFailure.firstMatch(exceptionString); | ||
| if (licenseMatch != null) { | ||
| final String missingLicenses = licenseMatch.group(1); | ||
| if (matcher.isNotEmpty) { |
Contributor
There was a problem hiding this comment.
matcher is a constant string. Did you mean missingLicenses?
And what if missingLicenses is empty -- there's still a problem with the licenses (since we have a match), but we don't tell users how to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the common Gradle failure where a project specifies a set of Android SDK components not currently downloaded, and the license for those components has not been accepted.
Fixes #8438
Sample output: