Skip to content

Add documentation on how to use dart-define with gradlew#123205

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Sese-Schneider:patch-1
Mar 29, 2023
Merged

Add documentation on how to use dart-define with gradlew#123205
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Sese-Schneider:patch-1

Conversation

@Sese-Schneider
Copy link
Contributor

@Sese-Schneider Sese-Schneider commented Mar 22, 2023

Add documentation on how to use --dart-define command line arguments when building the app via gradlew.

Resolves #100292
Related: flutter/website#8417

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Mar 22, 2023
@Sese-Schneider
Copy link
Contributor Author

Sese-Schneider commented Mar 28, 2023

Is there any interest in merging this PR?

I think the labels are wrong @Piinks (pinging you since you seem to handle most documentation PRs)

reidbaker
reidbaker approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh today I learned.

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation autosubmit Merge PR when tree becomes green via auto submit App labels Mar 29, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 29, 2023

auto label is removed for flutter/flutter, pr: 123205, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

Piinks
Piinks reviewed Mar 29, 2023
View reviewed changes
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 29, 2023

auto label is removed for flutter/flutter, pr: 123205, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit auto-submit bot merged commit 4e1ad59 into flutter:master Mar 29, 2023
@Sese-Schneider Sese-Schneider deleted the patch-1 branch March 30, 2023 08:13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
428b7e9 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
28ebf7e 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
c0d7e9c 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
82ff285 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
f8de3e4 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
e1002f7 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
28a5c35 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
539d013 
…lutter/flutter#123205)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
ee7a3d6 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
460d618 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
b1048f9 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
933197f 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
b95562d 
…lutter/flutter#123205)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
5b5ec4b 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
09328cf 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
f2b2ea1 
…lutter/flutter#123205)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@Sese-Schneider @exaby73
Add documentation on how to use dart-define with gradlew (flutter…
0a60d56 
…#123205)

Add documentation on how to use `dart-define` with `gradlew`
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
5d1ee13 
…lutter/flutter#123205)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4e1ad59 Add documentation on how to use dart-define with gradlew (f…
2a3e615 
…lutter/flutter#123205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks left review comments

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Document] Usage of Dart-Define variables in gradle scripts

4 participants

@Sese-Schneider @reidbaker @Piinks @pdblasi-google