[macOS] Battery check in platform_channel sample#123354
Merged
cbracken merged 2 commits intoflutter:masterfrom Mar 23, 2023
Merged
[macOS] Battery check in platform_channel sample#123354cbracken merged 2 commits intoflutter:masterfrom
cbracken merged 2 commits intoflutter:masterfrom
Conversation
Adds a check for the case where a device has no battery present. The devicelab test expects the text "No battery." in the case where a device has no battery. This is triggered by returning an error with a NO_BATTERY error code. Issue: flutter#79204
flutter-dashboard
bot
added
d: examples
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
loic-sharma
approved these changes
Mar 23, 2023
Contributor
|
test-exempt: is a test |
8 tasks
jmagman
approved these changes
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2023
This was referenced Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check for the case where a device has no battery present. The devicelab test expects the text "No battery." in the case where a device has no battery. This is triggered by returning an error with a NO_BATTERY error code.
Also fixes a missing return statement after returning an error.
No new test code since this fixes an existing (failing) devicelab test in bringup status, which was added in #123141
Issue: #79204
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.