[macOS] platform_channel sample style cleanups#123569
[macOS] platform_channel sample style cleanups#123569auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
Applies a few Swift style cleanups to the macOS platform_channel sample. Also adds ChannelName, BatteryState, ErrorCode enums to bring the example a bit closer to the iOS Swift example. Will follow up with a patch that applies relevant style fixes to the iOS Swift example. No test changes since app semantics have not changed. Issue: flutter#79204
flutter-dashboard
bot
added
d: examples
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
May need to request test exempt to land. The unit test is not needed since it's example code.
Added to make it similar to the iOS swift example, but it's inconsistent with the rest of the samples, irrelevant to demonstrating channels, and makes it so the useful code is all hidden below the fold, so to speak.
|
test-exempt: code refactor with no semantic change |
cbracken
added
the
autosubmit
3 participants
Applies a few Swift style cleanups to the macOS platform_channel sample.
Also adds ChannelName, BatteryState, ErrorCode enums to bring the example a bit closer to the iOS Swift example. Will follow up with a patch that applies relevant style fixes to the iOS Swift example.
No test changes since app semantics have not changed.
Issue: #79204
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.