Serve DevTools when running flutter test#123607
Merged
Conversation
Also clean up messaging output by `flutter test` when `--start-paused` is provided.
flutter-dashboard
bot
added
the
tool
Contributor
Author
|
I ran a search for any tests relying on the output of |
kenzieschmoll
approved these changes
Mar 28, 2023
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
one comment regarding what we are printing to console in the null case, but lgtm from DevTools perspective.
zanderso
reviewed
Mar 28, 2023
| ); | ||
| } | ||
|
|
||
| Future<void> _startDevTools(Uri forwardingUri, DartDevelopmentService? dds) async { |
Member
There was a problem hiding this comment.
Do we already have code similar to this anywhere else in the tool?
Contributor
Author
There was a problem hiding this comment.
We do have code that's tightly coupled to ResidentRunner in the form of ResidentDevtoolsHandler. I pulled the relevant code out for use here since flutter test doesn't require any of the functionality from ResidentDevtoolsHandler.
Contributor
Author
|
@zanderso can we land this? |
zanderso
approved these changes
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
zanderso
added a commit
that referenced
this pull request
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
bkonyi
added a commit
that referenced
this pull request
Apr 3, 2023
Originally reverted due to a misattributed hot reload benchmark regression. This reverts commit f5bce71.
bkonyi
added a commit
that referenced
this pull request
Apr 4, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
Also clean up messaging output by `flutter test` when `--start-paused` is provided.
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#123810) This reverts commit c3de901.
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124058) Originally reverted due to a misattributed hot reload benchmark regression. This reverts commit f5bce71.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also clean up messaging output by
flutter testwhen--start-pausedis provided.