Setup channels during IntegrationTest registration on iOS by jmagman · Pull Request #123729 · flutter/flutter

jmagman · 2023-03-29T22:44:00Z

Allow iOS integration_tests to run from flutter drive and not just Xcode.

I wasn't able to get the originally reported stuck runloop from #48601 to reproduce, even when I totally reverted flutter/plugins#2465. I also validated flutter/plugins#2514 passes when it's reverted.

Talked to @gaaclarke and we suspect some precondition for the original bug have been resolved... somewhere. This code was moved from flutter/plugins to the SDK, making bisecting this tricky, and probably not worth it if I can't reproduce it from Xcode or the command line at all with either a static or dynamic linked integration_test. So let's try re-adding the +registerWithRegistrar channel setup removed in #48601.

Reverts flutter/plugins#2465 (not a clean revert but essentially the same thing).

Fixes #91668
Closes #116539

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2023-03-30T02:33:02Z

packages/integration_test/ios/Classes/IntegrationTestPlugin.h

-+ (IntegrationTestPlugin *)instance;
-
- (void)setupChannels:(id<FlutterBinaryMessenger>)binaryMessenger;
+ (instancetype)instance;


Made this instancetype, that wasn't part of the revert.

pdblasi-google

LGTM!

pdblasi-google · 2023-03-30T20:21:11Z

packages/integration_test/ios/Classes/IntegrationTestPlugin.m

-  }];
+  FlutterMethodChannel *channel = [FlutterMethodChannel methodChannelWithName:kIntegrationTestPluginChannel
+                                                              binaryMessenger:registrar.messenger];
+  [registrar addMethodCallDelegate:[self instance] channel:channel];


For future archeologists: The addMethodCallDelegate does the setMethodCallHandler logic that was originally used, so this is semantically the same as the previous setMethodCallHandler call.

…utter/flutter#123729)

…3729) Setup channels during IntegrationTest registration on iOS

zubriktomas · 2023-04-17T13:22:03Z

@pdblasi-google Hello, could you please tell me when do you expect this fix to be part of what future release?

pdblasi-google · 2023-04-17T16:56:22Z

@zubriktomas

From the release process docs this is already available in the master channel and may be in beta as well. I'm not personally sure when it'll be a part of a stable release, but it should be in either the next stable or the one after that.

…utter/flutter#123729)

Setup channels during IntegrationTest registration on iOS

4b020c7

jmagman added the f: integration_test The flutter/packages/integration_test plugin label Mar 29, 2023

jmagman self-assigned this Mar 29, 2023

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 29, 2023

jmagman marked this pull request as ready for review March 30, 2023 02:30

jmagman requested review from gaaclarke and pdblasi-google March 30, 2023 02:32

jmagman commented Mar 30, 2023

View reviewed changes

pdblasi-google approved these changes Mar 30, 2023

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023

auto-submit bot merged commit 64800c7 into flutter:master Mar 30, 2023

jmagman mentioned this pull request Mar 30, 2023

Update IntegrationTestPlugin.m #116539

Closed

8 tasks

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to d940f60b4680 (70 revisions) flutter/packages#3605

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

283c807

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to f6c2b10e1a98 (71 revisions) flutter/packages#3606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

2e22a4e

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to f5415a42d342 (72 revisions) flutter/packages#3607

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

64ffb28

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 63e30480cd51 (74 revisions) flutter/packages#3608

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

bd74448

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 9a344c2604ec (75 revisions) flutter/packages#3609

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

394431a

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to a8117bf18778 (76 revisions) flutter/packages#3610

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

249800a

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 9d820aa35a22 (77 revisions) flutter/packages#3611

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

c9b0a94

…utter/flutter#123729)

reidbaker mentioned this pull request Apr 1, 2023

Add Java-Gradle-AGP validation to flutter analyze #123916

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Apr 1, 2023

Roll Flutter from 12b36de8f7ac to 1d90b7654afa (91 revisions) flutter/packages#3617

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

b4526c4

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Apr 1, 2023

Roll Flutter from 12b36de8f7ac to 1d90b7654afa (91 revisions) flutter/packages#3618

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

7b2d9c9

…utter/flutter#123729)

engine-flutter-autoroll mentioned this pull request Apr 1, 2023

Roll Flutter from 12b36de8f7ac to 18c9fa6cc80e (92 revisions) flutter/packages#3619

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

64e063f

…utter/flutter#123729)

jmagman deleted the integration-test-register branch April 5, 2023 16:42

reidbaker mentioned this pull request Apr 5, 2023

Update getGradleVersion to ignore commented out lines #124260

Merged

8 tasks

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023

Setup channels during IntegrationTest registration on iOS (flutter#12…

8d41642

…3729) Setup channels during IntegrationTest registration on iOS

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

625754a

…utter/flutter#123729)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

64800c7 Setup channels during IntegrationTest registration on iOS (fl…

c5ad359

…utter/flutter#123729)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup channels during IntegrationTest registration on iOS#123729

Setup channels during IntegrationTest registration on iOS#123729
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jmagman:integration-test-register

jmagman commented Mar 29, 2023

Uh oh!

jmagman Mar 30, 2023

Uh oh!

pdblasi-google left a comment

Uh oh!

pdblasi-google Mar 30, 2023

Uh oh!

zubriktomas commented Apr 17, 2023

Uh oh!

pdblasi-google commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jmagman commented Mar 29, 2023

Pre-launch Checklist

Uh oh!

jmagman Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

pdblasi-google left a comment

Choose a reason for hiding this comment

Uh oh!

pdblasi-google Mar 30, 2023

Choose a reason for hiding this comment

Uh oh!

zubriktomas commented Apr 17, 2023

Uh oh!

pdblasi-google commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants