It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Thanks a lot for your contribution! Just left a few comments, but overall it looks great:)

Thanks a lot for the review! 💙🙌❤️ I've resolved all the comments.

The Google testing is failing. I don't think the failure is related to the code change. We might need to rebase master and re-submit to trigger the test again:) Thanks!

The Google testing is failing. I don't think the failure is related to the code change. We might need to rebase master and re-submit to trigger the test again:) Thanks!

Sure I'll rebase, but it failed for DanTup as well.

The Google testing is failing. I don't think the failure is related to the code change. We might need to rebase master and re-submit to trigger the test again:) Thanks!

I did rebase, I don't know how these other commits got added :(

I used GitHub's UI (1 click) for rebase.

Edit: Fixed it. I think bug is on GitHub.

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

auto label is removed for flutter/flutter, pr: 123775, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto label is removed for flutter/flutter, pr: 123775, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

This check is failing on all PRs at the moment.

Can we please add auto-submit label again?

Thank you for adding the label. Number of checks are 8 now, earlier there were 71.

auto label is removed for flutter/flutter, pr: 123775, Failed to merge pr#: 123775 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

auto label is removed for flutter/flutter, pr: 123775, Failed to merge pr#: 123775 with Pull request could not be merged: Required status check "ci.yaml validation" is expected..

Can I please get auto-submit label again? Sorry to bother again. Previous failure was due to an infra issue #124332.

All green now 💚

No worries. It looks like the Google tests are running now though.