Roll Flutter Engine from a10990314872 to 12126583a727 (2 revisions)#123893
Closed
engine-flutter-autoroll wants to merge 2 commits intoflutter:masterfrom
Conversation
fluttergithubbot
approved these changes
Mar 31, 2023
Contributor
|
auto label is removed for flutter/flutter, pr: 123893, due to - The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
Author
|
Commit queue failed; closing this roll. |
dkwingsmt
pushed a commit
to flutter/engine
that referenced
this pull request
Mar 31, 2023
Reverts #39958 Failing the roll to the framework starting with flutter/flutter#123893 One example: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20dart_plugin_registry_test/21819/overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/engine@a109903...1212658
2023-03-31 [email protected] [macOS] Change view ID to signed (flutter/engine#39958)
2023-03-31 [email protected] Roll Skia from 5f965db93be3 to 2b86c6d364d0 (4 revisions) (flutter/engine#40823)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md