Update integration tests and benchmarks in /dev to newest Gradle, AGP, and Kotlin#123910
Closed
bartekpacia wants to merge 8 commits intoflutter:masterfrom
bartekpacia:update_agp_and_gradle_integration_tests
Closed
Update integration tests and benchmarks in /dev to newest Gradle, AGP, and Kotlin#123910bartekpacia wants to merge 8 commits intoflutter:masterfrom bartekpacia:update_agp_and_gradle_integration_tests
/dev to newest Gradle, AGP, and Kotlin#123910bartekpacia wants to merge 8 commits intoflutter:masterfrom
bartekpacia:update_agp_and_gradle_integration_tests
Conversation
flutter-dashboard
bot
added
a: accessibility
bartekpacia
changed the title
/dev to newest Gradle and AGP/dev to newest Gradle, AGP, and Kotlin
Member
Author
|
This change effectively removes testing on older AGP versions. Not sure if that's what #123636 was about. I think it'd be nice if we had some policy for supporting Gradle and AGP (e.g: the current release and the last one). I can imagine some large projects are slow to migrate. If a policy like that would be implemented, then e.g. most of these lines wouldn't be needed anymore. At the same time, Gradle and AGP should be an implementation detail for most Flutter devs, one they shouldn't care about. |
find ./dev -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart
Member
Author
|
I don't have time to fix the failing tests :( hopefully someone else picks this up in the future! |
8 tasks
fluttermirroringbot
pushed a commit
that referenced
this pull request
Jun 30, 2023
Upgrades tests under `dev/integration_tests` to use the latest values [in the templates](https://github.com/flutter/flutter/blob/944d6c8fef76b2db7a2c33eeb1653de2b8571fd8/dev/tools/bin/generate_gradle_lockfiles.dart#L135). Most of this PR was auto-generated, by running `find dev/integration_tests/ -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart` from the root of the flutter directory. The pieces that were not are: 1. Upgrading the Gradle versions used in integration tests to be >=7.4, in places where it was currently lower. 2. Upgrading the mac, windows, and linux build_tests .ci.yaml configuration to use jdk 17 on all shards. It currently was using a mix of 17 and 11. This isn't desirable, because some of the tests require 17, and the distribution is [random across shards](https://github.com/flutter/flutter/blob/cef9a8c54b766fa5f66e6fbdf7df341176f8e29f/dev/bots/test.dart#L553) (so they were only passing because they were getting randomly placed on shards using jdk 17). 3. Adding a dependency on jdk 11 for the tests based on the `firebaselab/firebaselab` recipe. Previously they had no java dependency, and were therefore defaulting to java 1.8. The newer AGP versions necessitated an upgrade to 11 to run. Note that it also ended up downgrading the AGP version in two places (in the [hybrid_android_views](https://github.com/flutter/flutter/pull/129642/files#diff-d7cfaa1c96d5c2383e7fc253ac8c9df062b544c24f7d80aa8a02290c01d17205L17) and [platform_interaction](https://github.com/flutter/flutter/pull/129642/files#diff-b2fba811efadd1cfb097bebd93be99fe4b6d6f17aefa863267290fc704290766L17) tests), because those had been manually edited to a newer version than the template. Related to: #123636, #123910
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #123636
Pre-launch Checklist
///).