Update `ThemeData`'s factory method documents by kj415j45 · Pull Request #123984 · flutter/flutter

kj415j45 · 2023-04-03T02:46:35Z

Catch up document. As Material 3 actually use a purple theme.

flutter/packages/flutter/lib/src/material/theme_data.dart

Lines 2777 to 2856 in d8cbaf6

    
           // BEGIN GENERATED TOKEN PROPERTIES - ColorScheme 
        
           // Do not edit by hand. The code between the "BEGIN GENERATED" and 
        
           // "END GENERATED" comments are generated from data in the Material 
        
           // Design token database by the script: 
        
           //   dev/tools/gen_defaults/bin/gen_defaults.dart. 
        
           // Token database version: v0_162 
        
           const ColorScheme _colorSchemeLightM3 = ColorScheme( 
        
             brightness: Brightness.light, 
        
             primary: Color(0xFF6750A4), 
        
             onPrimary: Color(0xFFFFFFFF), 
        
             primaryContainer: Color(0xFFEADDFF), 
        
             onPrimaryContainer: Color(0xFF21005D), 
        
             secondary: Color(0xFF625B71), 
        
             onSecondary: Color(0xFFFFFFFF), 
        
             secondaryContainer: Color(0xFFE8DEF8), 
        
             onSecondaryContainer: Color(0xFF1D192B), 
        
             tertiary: Color(0xFF7D5260), 
        
             onTertiary: Color(0xFFFFFFFF), 
        
             tertiaryContainer: Color(0xFFFFD8E4), 
        
             onTertiaryContainer: Color(0xFF31111D), 
        
             error: Color(0xFFB3261E), 
        
             onError: Color(0xFFFFFFFF), 
        
             errorContainer: Color(0xFFF9DEDC), 
        
             onErrorContainer: Color(0xFF410E0B), 
        
             background: Color(0xFFFFFBFE), 
        
             onBackground: Color(0xFF1C1B1F), 
        
             surface: Color(0xFFFFFBFE), 
        
             onSurface: Color(0xFF1C1B1F), 
        
             surfaceVariant: Color(0xFFE7E0EC), 
        
             onSurfaceVariant: Color(0xFF49454F), 
        
             outline: Color(0xFF79747E), 
        
             outlineVariant: Color(0xFFCAC4D0), 
        
             shadow: Color(0xFF000000), 
        
             scrim: Color(0xFF000000), 
        
             inverseSurface: Color(0xFF313033), 
        
             onInverseSurface: Color(0xFFF4EFF4), 
        
             inversePrimary: Color(0xFFD0BCFF), 
        
             // The surfaceTint color is set to the same color as the primary. 
        
             surfaceTint: Color(0xFF6750A4), 
        
           ); 
        
           const ColorScheme _colorSchemeDarkM3 = ColorScheme( 
        
             brightness: Brightness.dark, 
        
             primary: Color(0xFFD0BCFF), 
        
             onPrimary: Color(0xFF381E72), 
        
             primaryContainer: Color(0xFF4F378B), 
        
             onPrimaryContainer: Color(0xFFEADDFF), 
        
             secondary: Color(0xFFCCC2DC), 
        
             onSecondary: Color(0xFF332D41), 
        
             secondaryContainer: Color(0xFF4A4458), 
        
             onSecondaryContainer: Color(0xFFE8DEF8), 
        
             tertiary: Color(0xFFEFB8C8), 
        
             onTertiary: Color(0xFF492532), 
        
             tertiaryContainer: Color(0xFF633B48), 
        
             onTertiaryContainer: Color(0xFFFFD8E4), 
        
             error: Color(0xFFF2B8B5), 
        
             onError: Color(0xFF601410), 
        
             errorContainer: Color(0xFF8C1D18), 
        
             onErrorContainer: Color(0xFFF9DEDC), 
        
             background: Color(0xFF1C1B1F), 
        
             onBackground: Color(0xFFE6E1E5), 
        
             surface: Color(0xFF1C1B1F), 
        
             onSurface: Color(0xFFE6E1E5), 
        
             surfaceVariant: Color(0xFF49454F), 
        
             onSurfaceVariant: Color(0xFFCAC4D0), 
        
             outline: Color(0xFF938F99), 
        
             outlineVariant: Color(0xFF49454F), 
        
             shadow: Color(0xFF000000), 
        
             scrim: Color(0xFF000000), 
        
             inverseSurface: Color(0xFFE6E1E5), 
        
             onInverseSurface: Color(0xFF313033), 
        
             inversePrimary: Color(0xFF6750A4), 
        
             // The surfaceTint color is set to the same color as the primary. 
        
             surfaceTint: Color(0xFFD0BCFF), 
        
           ); 
        
           // END GENERATED TOKEN PROPERTIES - ColorScheme

flutter-dashboard · 2023-05-18T00:55:31Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

HansMuller

Sorry, we seem to have overlooked this PR. It's a good change.

auto-submit · 2023-08-01T18:01:45Z

auto label is removed for flutter/flutter, pr: 123984, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Hixie

Hixie · 2023-08-01T18:02:49Z

@kj415j45 thanks for the contribution!

auto-submit · 2023-08-01T18:25:00Z

auto label is removed for flutter/flutter, pr: 123984, due to - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-08-01T20:58:22Z

auto label is removed for flutter/flutter, pr: 123984, due to - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux firebase_android_embedding_v2_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-08-01T21:38:05Z

auto label is removed for flutter/flutter, pr: 123984, due to - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-08-02T00:59:04Z

auto label is removed for flutter/flutter, pr: 123984, due to - The status or check suite Linux web_canvaskit_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r#123984)

Catch up document. As Material 3 actually use a purple theme. https://github.com/flutter/flutter/blob/d8cbaf62615497fdb1e51167d0eb306a2d7b7bcf/packages/flutter/lib/src/material/theme_data.dart#L2777-L2856

Roll Flutter from 1d59196 to b3f99ff (32 revisions) flutter/flutter@1d59196...b3f99ff 2023-08-02 [email protected] Fix reentrancy with WidgetBindingObserver callbacks (flutter/flutter#131774) 2023-08-02 [email protected] Update .ci.yaml to add new shard to prevent timeouts (flutter/flutter#131712) 2023-08-02 [email protected] Fix flex methods for min and max column widths (flutter/flutter#131724) 2023-08-02 [email protected] Manual roll Flutter Engine from 9dae7b708bda to d6b962d0e36d (25 revisions) (flutter/flutter#131785) 2023-08-02 [email protected] Added standard deviation to rasterizer results. (flutter/flutter#131781) 2023-08-02 [email protected] Tiny remove outdated comments (flutter/flutter#130387) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump ubuntu from `f8f6584` to `c9820a4` in /dev/ci/docker_linux (flutter/flutter#130292) 2023-08-02 [email protected] Fix for endless recursion for getLayoutExplorerNode on a Tooltip (flutter/flutter#131486) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/flutter#126600) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.0 to 4.0.1 (flutter/flutter#128741) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.3 to 3.1.4 (flutter/flutter#126885) 2023-08-02 [email protected] Update `ThemeData`'s factory method documents (flutter/flutter#123984) 2023-08-02 [email protected] Fix Scrollable `TabBar` for Material 3 (flutter/flutter#131409) 2023-08-02 [email protected] ImageProvider.toString uses double.toStringAsFixed (flutter/flutter#131348) 2023-08-02 [email protected] Roll Flutter Engine from 10a1f9cb74c9 to 9dae7b708bda (4 revisions) (flutter/flutter#131706) 2023-08-01 [email protected] Upgrade Flutter libraries. (flutter/flutter#131700) 2023-08-01 [email protected] Roll Flutter Engine from 1aadc75dd5a7 to 10a1f9cb74c9 (1 revision) (flutter/flutter#131696) 2023-08-01 [email protected] Roll Flutter Engine from e3f817ce9953 to 1aadc75dd5a7 (2 revisions) (flutter/flutter#131691) 2023-08-01 [email protected] Roll Packages from 60e9a54 to 3dc00c1 (5 revisions) (flutter/flutter#131692) 2023-08-01 [email protected] Avoid concurrent modification of persistent frame callbacks (flutter/flutter#131677) 2023-08-01 [email protected] Roll Flutter Engine from ae535c024146 to e3f817ce9953 (1 revision) (flutter/flutter#131687) 2023-08-01 [email protected] Roll Flutter Engine from 703d45539059 to ae535c024146 (4 revisions) (flutter/flutter#131679) 2023-08-01 [email protected] Roll Flutter Engine from f1c80ce98499 to 703d45539059 (1 revision) (flutter/flutter#131668) 2023-08-01 [email protected] Roll Flutter Engine from 2583c07f6a69 to f1c80ce98499 (1 revision) (flutter/flutter#131663) 2023-08-01 [email protected] Roll Flutter Engine from 25b9d1088d09 to 2583c07f6a69 (1 revision) (flutter/flutter#131661) 2023-08-01 [email protected] Roll Flutter Engine from 7651b3cba6ba to 25b9d1088d09 (4 revisions) (flutter/flutter#131655) 2023-08-01 [email protected] Roll Flutter Engine from 1433e23c8a3d to 7651b3cba6ba (2 revisions) (flutter/flutter#131648) 2023-08-01 [email protected] Roll Flutter Engine from 791f505c8c6e to 1433e23c8a3d (1 revision) (flutter/flutter#131647) 2023-08-01 [email protected] Roll Flutter Engine from bb2a903c934c to 791f505c8c6e (4 revisions) (flutter/flutter#131645) 2023-08-01 [email protected] 🐛 Treat empty ARB content as empty map when decoding (flutter/flutter#131242) 2023-08-01 [email protected] Roll Flutter Engine from fe2369565f59 to bb2a903c934c (3 revisions) (flutter/flutter#131639) 2023-07-31 [email protected] Roll Flutter Engine from b83172a4e995 to fe2369565f59 (12 revisions) (flutter/flutter#131638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 3, 2023

kj415j45 changed the title ~~Correct document for light() and dark() factory.~~ Update ThemeData's factory method documents Apr 3, 2023

github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 30, 2023

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 1, 2023

HansMuller approved these changes Aug 1, 2023

View reviewed changes

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

Hixie approved these changes Aug 1, 2023

View reviewed changes

Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023

Correct document for light() and dark() factory.

648149f

HansMuller force-pushed the patch-1 branch from 37ab8c7 to 648149f Compare August 2, 2023 02:50

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023

auto-submit bot merged commit c51aa3d into flutter:master Aug 2, 2023

kj415j45 deleted the patch-1 branch August 2, 2023 03:56

engine-flutter-autoroll mentioned this pull request Aug 2, 2023

Roll Flutter from 1d59196bafdb to f80ff55a7675 (25 revisions) flutter/packages#4628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023

c51aa3d Update ThemeData's factory method documents (flutter/flutte…

b4e991e

…r#123984)

engine-flutter-autoroll mentioned this pull request Aug 2, 2023

Roll Flutter from 1d59196bafdb to 6cf50ef9427e (26 revisions) flutter/packages#4630

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023

c51aa3d Update ThemeData's factory method documents (flutter/flutte…

5ab9653

…r#123984)

engine-flutter-autoroll mentioned this pull request Aug 2, 2023

Roll Flutter from 1d59196bafdb to 947367aaa2fb (28 revisions) flutter/packages#4631

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023

c51aa3d Update ThemeData's factory method documents (flutter/flutte…

9ca1a81

…r#123984)

engine-flutter-autoroll mentioned this pull request Aug 2, 2023

Roll Flutter from 1d59196bafdb to f9e4567ff655 (29 revisions) flutter/packages#4632

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023

c51aa3d Update ThemeData's factory method documents (flutter/flutte…

599fe09

…r#123984)

engine-flutter-autoroll mentioned this pull request Aug 2, 2023

Roll Flutter from 1d59196bafdb to a12034292292 (30 revisions) flutter/packages#4633

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023

c51aa3d Update ThemeData's factory method documents (flutter/flutte…

dff249c

…r#123984)

engine-flutter-autoroll mentioned this pull request Aug 2, 2023

Roll Flutter from 1d59196bafdb to b3f99ffe610a (32 revisions) flutter/packages#4634

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023

c51aa3d Update ThemeData's factory method documents (flutter/flutte…

c8d2047

…r#123984)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `ThemeData`'s factory method documents#123984

Update `ThemeData`'s factory method documents#123984
auto-submit[bot] merged 1 commit intoflutter:masterfrom
kj415j45:patch-1

kj415j45 commented Apr 3, 2023

Uh oh!

flutter-dashboard bot commented May 18, 2023

Uh oh!

HansMuller left a comment

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

Hixie left a comment

Uh oh!

Hixie commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// BEGIN GENERATED TOKEN PROPERTIES - ColorScheme

	// Do not edit by hand. The code between the "BEGIN GENERATED" and
	// "END GENERATED" comments are generated from data in the Material
	// Design token database by the script:
	// dev/tools/gen_defaults/bin/gen_defaults.dart.

	// Token database version: v0_162

	const ColorScheme _colorSchemeLightM3 = ColorScheme(
	brightness: Brightness.light,
	primary: Color(0xFF6750A4),
	onPrimary: Color(0xFFFFFFFF),
	primaryContainer: Color(0xFFEADDFF),
	onPrimaryContainer: Color(0xFF21005D),
	secondary: Color(0xFF625B71),
	onSecondary: Color(0xFFFFFFFF),
	secondaryContainer: Color(0xFFE8DEF8),
	onSecondaryContainer: Color(0xFF1D192B),
	tertiary: Color(0xFF7D5260),
	onTertiary: Color(0xFFFFFFFF),
	tertiaryContainer: Color(0xFFFFD8E4),
	onTertiaryContainer: Color(0xFF31111D),
	error: Color(0xFFB3261E),
	onError: Color(0xFFFFFFFF),
	errorContainer: Color(0xFFF9DEDC),
	onErrorContainer: Color(0xFF410E0B),
	background: Color(0xFFFFFBFE),
	onBackground: Color(0xFF1C1B1F),
	surface: Color(0xFFFFFBFE),
	onSurface: Color(0xFF1C1B1F),
	surfaceVariant: Color(0xFFE7E0EC),
	onSurfaceVariant: Color(0xFF49454F),
	outline: Color(0xFF79747E),
	outlineVariant: Color(0xFFCAC4D0),
	shadow: Color(0xFF000000),
	scrim: Color(0xFF000000),
	inverseSurface: Color(0xFF313033),
	onInverseSurface: Color(0xFFF4EFF4),
	inversePrimary: Color(0xFFD0BCFF),
	// The surfaceTint color is set to the same color as the primary.
	surfaceTint: Color(0xFF6750A4),
	);

	const ColorScheme _colorSchemeDarkM3 = ColorScheme(
	brightness: Brightness.dark,
	primary: Color(0xFFD0BCFF),
	onPrimary: Color(0xFF381E72),
	primaryContainer: Color(0xFF4F378B),
	onPrimaryContainer: Color(0xFFEADDFF),
	secondary: Color(0xFFCCC2DC),
	onSecondary: Color(0xFF332D41),
	secondaryContainer: Color(0xFF4A4458),
	onSecondaryContainer: Color(0xFFE8DEF8),
	tertiary: Color(0xFFEFB8C8),
	onTertiary: Color(0xFF492532),
	tertiaryContainer: Color(0xFF633B48),
	onTertiaryContainer: Color(0xFFFFD8E4),
	error: Color(0xFFF2B8B5),
	onError: Color(0xFF601410),
	errorContainer: Color(0xFF8C1D18),
	onErrorContainer: Color(0xFFF9DEDC),
	background: Color(0xFF1C1B1F),
	onBackground: Color(0xFFE6E1E5),
	surface: Color(0xFF1C1B1F),
	onSurface: Color(0xFFE6E1E5),
	surfaceVariant: Color(0xFF49454F),
	onSurfaceVariant: Color(0xFFCAC4D0),
	outline: Color(0xFF938F99),
	outlineVariant: Color(0xFF49454F),
	shadow: Color(0xFF000000),
	scrim: Color(0xFF000000),
	inverseSurface: Color(0xFFE6E1E5),
	onInverseSurface: Color(0xFF313033),
	inversePrimary: Color(0xFF6750A4),
	// The surfaceTint color is set to the same color as the primary.
	surfaceTint: Color(0xFFD0BCFF),
	);

	// END GENERATED TOKEN PROPERTIES - ColorScheme

Conversation

kj415j45 commented Apr 3, 2023

Uh oh!

flutter-dashboard bot commented May 18, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

Hixie left a comment

Choose a reason for hiding this comment

Uh oh!

Hixie commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 1, 2023

Uh oh!

auto-submit bot commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants