Skip to content

Revert "Fix scrolling in the Drawer and NavigationDrawer triggers AppBar's scrolledUnderElevation (#122600)"#124187

Closed
TahaTesser wants to merge 1 commit intoflutter:masterfrom
NevercodeHQ:revert-122600
Closed

Revert "Fix scrolling in the Drawer and NavigationDrawer triggers AppBar's scrolledUnderElevation (#122600)"#124187
TahaTesser wants to merge 1 commit intoflutter:masterfrom
NevercodeHQ:revert-122600

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Apr 5, 2023 •
edited
Loading

This reverts 6e04bdd

closes #123782

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser
Revert "Fix scrolling in the Drawer and NavigationDrawer triggers…
7101cd0 
… AppBar's scrolledUnderElevation (flutter#122600)"

This reverts commit 6e04bdd.
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 5, 2023
@TahaTesser TahaTesser mentioned this pull request Apr 5, 2023
Merged
8 tasks
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124187, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso
Copy link
Member

zanderso commented Apr 5, 2023

The Google Testing failures look unrelated. Re-basing this PR will probably help.

@Piinks
Copy link
Contributor

Piinks commented Apr 5, 2023

The button to rebase the PR is not here. :(
Taha is OOO until next week now, so I am going to close this and open a new PR (since this does not allow others to modify it) so we can get this reverted. There is a setting AFAIK when you open a PR to allow maintainers to edit.

@Piinks Piinks closed this Apr 5, 2023
@Piinks Piinks mentioned this pull request Apr 5, 2023
Merged
@TahaTesser TahaTesser deleted the revert-122600 branch April 5, 2023 16:58
@TahaTesser
Copy link
Contributor Author

TahaTesser commented Apr 5, 2023

The button to rebase the PR is not here. :( Taha is OOO until next week now, so I am going to close this and open a new PR (since this does not allow others to modify it) so we can get this reverted. There is a setting AFAIK when you open a PR to allow maintainers to edit.

Thank you for taking action

@Piinks
Copy link
Contributor

Piinks commented Apr 5, 2023

Of course! Go be on vacation! Shoo! 😁 🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bleroux bleroux bleroux approved these changes

@zanderso zanderso Awaiting requested review from zanderso

@Piinks Piinks Awaiting requested review from Piinks

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

~10% regression in stock layout iteration microbenchmark

5 participants

@TahaTesser @zanderso @Piinks @bleroux @HansMuller