Skip to content

Use term wireless instead of network#124232

Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom
vashworth:wireless_device_discovery_part_7
Apr 19, 2023
Merged

Use term wireless instead of network#124232
auto-submit[bot] merged 5 commits intoflutter:masterfrom
vashworth:wireless_device_discovery_part_7

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Apr 5, 2023 •
edited
Loading

Rename variables, update comments, etc from network to wireless to keep it more uniform.

Also, move non-overriden messages related to device selection into the file they're used.

Part 7 in breakdown of #121262.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 5, 2023
vashworth
vashworth commented Apr 5, 2023
View reviewed changes
packages/flutter_tools/lib/src/base/user_messages.dart
String flutterFoundSpecifiedDevices(int count, String deviceId) =>
'Found $count devices with name or id matching $deviceId:';
String flutterChooseDevice(int option, String name, String deviceId) => '[$option]: $name ($deviceId)';
String get flutterChooseOne => 'Please choose one (or "q" to quit)';
Copy link
Contributor Author

@vashworth vashworth Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved messages as per this comment from original PR: https://github.com/flutter/flutter/pull/121262/files#r1115130107

@vashworth vashworth marked this pull request as ready for review April 5, 2023 18:33
@vashworth vashworth requested a review from jmagman April 5, 2023 18:33
jmagman
jmagman approved these changes Apr 5, 2023
View reviewed changes
packages/flutter_tools/lib/src/mdns_discovery.dart
/// to find.
///
/// The [isNetworkDevice] parameter flags whether to get the device IP
/// The [useDeviceIPAsHost] parameter flags whether to get the device IP
Copy link
Member

@jmagman jmagman Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this as use Device IPAs Host (like an .ipa) which is confusing but I don't have a better suggestion.

@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 13, 2023

@vashworth are you ready to merge this one?

@jmagman
Copy link
Member

jmagman commented Apr 13, 2023

@vashworth are you ready to merge this one?

She'll follow up next week.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
@auto-submit auto-submit bot merged commit 48bb3c0 into flutter:master Apr 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
255500a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
82b0c8c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
fad8166
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
9277b62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
ce3aecf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
e1de279
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
2feb38b
@reidbaker reidbaker mentioned this pull request Apr 20, 2023
Closed
8 tasks
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
bcdd77e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
2786e70
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
0bff8b3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
9b27446
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
4ea34f5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
de305bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
f271501
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
7c585d4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
2dd7c98
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
6764f80
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
32226c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
effe94e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
48bb3c0 Use term wireless instead of network (flutter/flutter#124232)
aad974b
@vashworth vashworth deleted the wireless_device_discovery_part_7 branch September 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vashworth @christopherfujino @jmagman