Debounce the proxied connection over proxied devices.#124540
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Apr 10, 2023
Merged
Debounce the proxied connection over proxied devices.#124540auto-submit[bot] merged 3 commits intoflutter:masterfrom
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
This improves performance when there are many small packets being sent, especially when attaching a debugger.
flutter-dashboard
bot
added
the
tool
| expect(source.hasListener, true); | ||
| }); | ||
|
|
||
| testWithoutContext('forwards data normally is all data is longer than duration apart', () { |
Contributor
There was a problem hiding this comment.
Suggested change
| testWithoutContext('forwards data normally is all data is longer than duration apart', () { | |
| testWithoutContext('forwards data normally if all data is longer than duration apart', () { |
Contributor
Author
There was a problem hiding this comment.
Nice catch. Fixed!
christopherfujino
approved these changes
Apr 10, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, and thanks for the very clear easy to read tests! I always struggle testing anything async...
chingjun
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
Debounce the proxied connection over proxied devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves performance when there are many small packets being sent, especially when attaching a debugger.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.