Update helper message for `--suppress-analytics` by eliasyishak · Pull Request #124810 · flutter/flutter

eliasyishak · 2023-04-13T18:29:53Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…g-and-suppressing-analytics

christopherfujino · 2023-04-13T20:26:10Z

Can you also update the printStatus in packages/flutter_tools/lib/runner.dart to only suggest using flutter --disable-telemetry?

…age now

eliasyishak · 2023-04-17T16:26:31Z

packages/flutter_tools/lib/runner.dart

-        // If the user has opted out of legacy analytics, we will continue
-        // to opt them out of unified analytics and inform them
-        if (!globals.flutterUsage.enabled && globals.analytics.telemetryEnabled) {
-          await globals.analytics.setTelemetry(false);
-          globals.logger.printStatus(
-              'Please note that analytics reporting was already disabled, and will continue to be disabled.\n');
-        }
-


fyi @christopherfujino , the unified analytics implementation team decided that we should have the package be responsible for checking the legacy opt out status.

This PR (dart-lang/tools#80) has the changes to pass legacy opt out status to unified analytics.

Ok, so I'm guessing landing this PR is blocked on rolling package:unified_analytics?

Yep, I'm going to confirm that the package is rolled first before landing this

Actually, we have to ensure that the new version of package:unified_analytics has rolled to the analyzer, which has rolled to the Dart SDK, which has rolled to the engine, which has rolled to the framework, right?

We have bumped the hash on the dart sdk side in the DEPS file now, does this PR #125005 mean that the package update has made it to the framework now?

I'm seeing in g3 that the latest version for the package has actually been rolled so i think once the package has been updated in #125005, then we can land this PR

eliasyishak · 2023-04-17T16:27:36Z

packages/flutter_tools/test/general.shard/runner/runner_test.dart

-
-    testUsingContext(
-      'legacy analytics disabled will disable new analytics',
-      () async {
-
-        io.setExitFunctionForTests((int exitCode) {});
-
-        await runner.run(
-          <String>[],
-          () => <FlutterCommand>[],
-          // This flutterVersion disables crash reporting.
-          flutterVersion: '[user-branch]/',
-          shutdownHooks: ShutdownHooks(),
-        );
-
-        expect(globals.flutterUsage.enabled, false);
-        expect(globals.analytics.telemetryEnabled, false);
-        expect(testLogger.statusText.contains(
-          'Please note that analytics '
-          'reporting was already disabled'), true);
-      },
-      overrides: <Type, Generator>{
-        Analytics: () => FakeAnalytics(),
-        FileSystem: () => MemoryFileSystem.test(),
-        ProcessManager: () => FakeProcessManager.any(),
-        Usage: () => legacyAnalytics,
-      },
-    );


This test was no longer necessary since legacy opt out status will be honored from within package:unified_analytics for every tool using that package

packages/flutter_tools/lib/runner.dart

packages/flutter_tools/lib/src/runner/flutter_command_runner.dart

christopherfujino

Two nits about messaging text, otherwise LGTM

…ted out

…g-and-suppressing-analytics

…tter#124810)

This reverts commit 3476b96.

Reverts #124810

flutter/flutter@42fb0b2...3476b96 2023-04-19 [email protected] Update helper message for `--suppress-analytics` (flutter/flutter#124810) 2023-04-19 [email protected] Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (flutter/flutter#125097) 2023-04-19 [email protected] Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (flutter/flutter#125094) 2023-04-19 [email protected] Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (flutter/flutter#125078) 2023-04-19 [email protected] Disableable ContextMenuButtonItems (flutter/flutter#124253) 2023-04-18 [email protected] Adaptive alert dialog (flutter/flutter#124336) 2023-04-18 [email protected] Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (flutter/flutter#125069) 2023-04-18 [email protected] Remove package:js/dart:js_interop conflicts (flutter/flutter#124879) 2023-04-18 [email protected] Remove double.fromEnvironment from dart-define doc (flutter/flutter#124102) 2023-04-18 [email protected] Update to add Kim Jiun to `AUTHORS` (flutter/flutter#125026) 2023-04-18 [email protected] Add controller argument to SubmenuButton (flutter/flutter#125000) 2023-04-18 [email protected] Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (flutter/flutter#125060) 2023-04-18 [email protected] Limit the number of Material spell check suggestions to 3 (flutter/flutter#124899) 2023-04-18 [email protected] Remove impeller testowners (flutter/flutter#125056) 2023-04-18 [email protected] [web] - Clean up skipped tests (flutter/flutter#124981) 2023-04-18 [email protected] Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (flutter/flutter#125057) 2023-04-18 [email protected] Remove unused getRootRenderObject and getSelectedRenderObject service extensions (flutter/flutter#124805) 2023-04-18 [email protected] l10n.yaml's nullable-getter option should default to true (flutter/flutter#124353) 2023-04-18 [email protected] Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (flutter/flutter#125053) 2023-04-18 [email protected] Add vmservice for android build options (flutter/flutter#123034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Relanding: #124810 Fixes: #124808

…5145) Relanding: flutter#124810 Fixes: flutter#124808

flutter/flutter@42fb0b2...3476b96 2023-04-19 [email protected] Update helper message for `--suppress-analytics` (flutter/flutter#124810) 2023-04-19 [email protected] Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (flutter/flutter#125097) 2023-04-19 [email protected] Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (flutter/flutter#125094) 2023-04-19 [email protected] Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (flutter/flutter#125078) 2023-04-19 [email protected] Disableable ContextMenuButtonItems (flutter/flutter#124253) 2023-04-18 [email protected] Adaptive alert dialog (flutter/flutter#124336) 2023-04-18 [email protected] Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (flutter/flutter#125069) 2023-04-18 [email protected] Remove package:js/dart:js_interop conflicts (flutter/flutter#124879) 2023-04-18 [email protected] Remove double.fromEnvironment from dart-define doc (flutter/flutter#124102) 2023-04-18 [email protected] Update to add Kim Jiun to `AUTHORS` (flutter/flutter#125026) 2023-04-18 [email protected] Add controller argument to SubmenuButton (flutter/flutter#125000) 2023-04-18 [email protected] Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (flutter/flutter#125060) 2023-04-18 [email protected] Limit the number of Material spell check suggestions to 3 (flutter/flutter#124899) 2023-04-18 [email protected] Remove impeller testowners (flutter/flutter#125056) 2023-04-18 [email protected] [web] - Clean up skipped tests (flutter/flutter#124981) 2023-04-18 [email protected] Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (flutter/flutter#125057) 2023-04-18 [email protected] Remove unused getRootRenderObject and getSelectedRenderObject service extensions (flutter/flutter#124805) 2023-04-18 [email protected] l10n.yaml's nullable-getter option should default to true (flutter/flutter#124353) 2023-04-18 [email protected] Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (flutter/flutter#125053) 2023-04-18 [email protected] Add vmservice for android build options (flutter/flutter#123034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update helper message for --suppress-analytics

36ba3eb

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 13, 2023

Merge branch 'master' into 124808-clean-up-help-messages-for-disablin…

b07595d

…g-and-suppressing-analytics

eliasyishak added 2 commits April 14, 2023 09:03

Removing logic for opting out due to legacy opt – handled in the pack…

b1898fd

…age now

Remove test – this is handled by package:unified_analytics now

4e185c2

eliasyishak requested a review from christopherfujino April 17, 2023 16:24

eliasyishak commented Apr 17, 2023

View reviewed changes

eliasyishak marked this pull request as ready for review April 17, 2023 16:26

eliasyishak commented Apr 17, 2023

View reviewed changes

christopherfujino reviewed Apr 17, 2023

View reviewed changes

packages/flutter_tools/lib/runner.dart Outdated Show resolved Hide resolved

christopherfujino reviewed Apr 17, 2023

View reviewed changes

packages/flutter_tools/lib/src/runner/flutter_command_runner.dart Outdated Show resolved Hide resolved

christopherfujino approved these changes Apr 17, 2023

View reviewed changes

eliasyishak added 3 commits April 17, 2023 17:04

Nits

10dc256

Message added to let opted out users know they will continue to be op…

42c8064

…ted out

Merge branch 'master' into 124808-clean-up-help-messages-for-disablin…

21d1c17

…g-and-suppressing-analytics

eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023

auto-submit bot merged commit 3476b96 into flutter:master Apr 19, 2023

engine-flutter-autoroll mentioned this pull request Apr 19, 2023

Roll Flutter from 42fb0b23139c to 3476b966524f (20 revisions) flutter/packages#3760

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2023

3476b96 Update helper message for --suppress-analytics (flutter/flu…

b2cd8f4

…tter#124810)

godofredoc added a commit that referenced this pull request Apr 19, 2023

Revert "Update helper message for --suppress-analytics (#124810)"

ff21774

This reverts commit 3476b96.

godofredoc mentioned this pull request Apr 19, 2023

Revert "Update helper message for --suppress-analytics" #125141

Merged

auto-submit bot mentioned this pull request Apr 19, 2023

Review request for Revert PR flutter/flutter#125141 #125142

Closed

auto-submit bot pushed a commit that referenced this pull request Apr 19, 2023

Revert "Update helper message for --suppress-analytics" (#125141)

03d7256

Reverts #124810

eliasyishak mentioned this pull request Apr 19, 2023

[reland] Update helper message for --suppress-analytics #125145

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Apr 19, 2023

[reland] Update helper message for --suppress-analytics (#125145)

ca3a900

Relanding: #124810 Fixes: #124808

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

Test AGP 8.0 using java 17 #125323

Merged

eliasyishak added a commit to eliasyishak/flutter that referenced this pull request Apr 24, 2023

[reland] Update helper message for --suppress-analytics (flutter#12…

6f45d9b

…5145) Relanding: flutter#124810 Fixes: flutter#124808

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update helper message for `--suppress-analytics`#124810

Update helper message for `--suppress-analytics`#124810
auto-submit[bot] merged 7 commits intoflutter:masterfrom
eliasyishak:124808-clean-up-help-messages-for-disabling-and-suppressing-analytics

eliasyishak commented Apr 13, 2023 •

edited

Loading

Uh oh!

christopherfujino commented Apr 13, 2023

Uh oh!

eliasyishak Apr 17, 2023

Uh oh!

christopherfujino Apr 17, 2023

Uh oh!

eliasyishak Apr 17, 2023

Uh oh!

christopherfujino Apr 17, 2023

Uh oh!

eliasyishak Apr 18, 2023

Uh oh!

eliasyishak Apr 18, 2023

Uh oh!

eliasyishak Apr 17, 2023

Uh oh!

Uh oh!

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eliasyishak commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

christopherfujino commented Apr 13, 2023

Uh oh!

eliasyishak Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

eliasyishak Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eliasyishak commented Apr 13, 2023 •

edited

Loading