iOS spell check cursor placement#124875
Merged
justinmc merged 3 commits intoflutter:masterfrom Apr 18, 2023
Merged
Conversation
flutter-dashboard
bot
added
f: cupertino
camsim99
approved these changes
Apr 17, 2023
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Nice fix! Just left a question
| } | ||
| }); | ||
| editableTextState.hideToolbar(); | ||
| editableTextState.renderEditable.selectWordEdge(cause: SelectionChangedCause.toolbar); |
Contributor
There was a problem hiding this comment.
I'm wondering why this didn't work as expected?
Contributor
Author
There was a problem hiding this comment.
This call was operating on the previous frame's TextEditingValue, so it didn't consider the userUpdateTextEditingValue call above. It was selecting the edge of the old word before that change.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 18, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 18, 2023
flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener call� (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Apr 20, 2023
8 tasks
justinmc
added a commit
to justinmc/flutter
that referenced
this pull request
Apr 25, 2023
Fixes the cursor location after selecting a spell check result on iOS.
itsjustkevin
pushed a commit
that referenced
this pull request
Apr 26, 2023
This is a cherry pick of 8 of my recent spell check bug fixes into the beta branch. 1. #124259 2. #124875 3. #124254 4. #124899 5. #124895 6. #125162 7. #124897 8. #125432 This is the behavior of spell check with these changes: | Screenshot | Video | | --- | --- | | <img src="proxy.php?url=https://user-images.githubusercontent.com/389558/234087650-bcd62c89-03e7-427d-afc5-0fe8f96a5f80.png" /> | <video src="proxy.php?url=https://user-images.githubusercontent.com/389558/234087667-651b0fde-348c-467e-ba00-27b6b3966a27.mov" /> | CC @itsjustkevin @leighajarett
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener call� (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the cursor might be put in the wrong place after choosing a spell check replacement on iOS. Now, it will always but put at the end of the new word.
Fixes #124405