Cp for gradle 8.0 support in flutter 3.7#124990
Cp for gradle 8.0 support in flutter 3.7#124990CaseyHillers merged 2 commits intoflutter:flutter-3.7-candidate.1from reidbaker:i124838-gradle-8-backport-flutter-3-7
Conversation
… that gradle 8.0 builds
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Fix Gradle 7 warnings that are now errors in Gradle 8
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:7.2.0' | ||
| classpath 'com.android.tools.build:gradle:7.3.0' |
There was a problem hiding this comment.
Out of curiosity, if there any reason why we couldn't start using a variable for version number like we do for the kotlin version?
There was a problem hiding this comment.
Agp version is more likely to cause you to have to make updates to your app than kotlin version or gradle version. Nothing mechanically stops us but I think leaving this version where it is easy for the Android Studio tooling to update is the best policy. That said it does probably make sense to have a version that can be shared for packages/packages.
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.2-bin.zip | |||
There was a problem hiding this comment.
I notice this changes from ***all.zip to ***bin.zip. Is there one we should generally prefer, or does it depend on the situation?
As I understand, its the difference of whether sources/documentation come bundled, but I'm not sure of the implications of that for all these gradle wrappers in /benchmarks, for example.
There was a problem hiding this comment.
I think for normal users all is probably safe since the size is not large. That said this is what is in the 3.10 branch and we dont want to make any changes.
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
The gradle changes look good, just had one question!
|
|
||
| include ':app' | ||
|
|
||
| enableFeaturePreview('ONE_LOCKFILE_PER_PROJECT') |
There was a problem hiding this comment.
This was removed in the original pr because one lockfile per project was an experimental feature that was promoted to stable.
flutter-dashboard
bot
added
the
c: contributor-productivity
|
Mac builds are failing because |
6 participants
Pull the minimal set of changes from flutter 3.10 (in beta) into flutter 3.7 to support gradle 8.0
124838
Original PR
Pre-launch Checklist
///).